On Wed, 9 Mar 2022 08:25:48 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
On Tue, 8 Mar 2022 16:13:08 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add test for DTLS
>
> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 501:
>
>> 499:
>> 5
On Sun, 6 Mar 2022 05:40:59 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Fri, 4 Mar 2022 16:29:04 GMT, Sean Mullan wrote:
> Since this new API is also intended to be supported for DTLS, have you added
> implementation support for that, and if so have you added a test for it?
Yes, the DTLS implementation is included. I added a test case for DTLS.
-
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
On Thu, 17 Feb 2022 18:57:02 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
On Wed, 16 Feb 2022 19:21:58 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
On Wed, 9 Feb 2022 21:38:22 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Spec update
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 749:
>
>> 747: * @implNote
On Wed, 9 Feb 2022 18:24:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Wed, 9 Feb 2022 14:33:11 GMT, Sean Mullan wrote:
>> Basically, the suggestion captures the implementation behaviors correctly.
>> To make it more accuracy, if we want to use it, we may need to consider more
>> cases:
>> 1. _explicitly set by application_, with null, empty or 1+ schemes.
>>
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
On Tue, 8 Feb 2022 23:36:05 GMT, Xue-Lei Andrew Fan wrote:
>> Ok, I get it now, the API wins if both are set. But I could not discern that
>> from the current text. I think it is ok to be more clear about this. I
>> suggest adding something like the following:
>>
>> "The set of signature schem
On Tue, 8 Feb 2022 20:18:20 GMT, Sean Mullan wrote:
>>> Are you maybe saying that this method returns the value of the system
>>> properties if they are set?
>>
>> The return value of this method depends on the following specs:
>>
>> * If the {@link #setSignatureSchemes} method has not be
On Mon, 7 Feb 2022 23:13:13 GMT, Xue-Lei Andrew Fan wrote:
>>> "If set, these properties will override the signature schemes returned by
>>> this method."
>>
>> If I understand your ideas correctly, the behavior should be "the returned
>> value of this method will override these properties", e
On Mon, 7 Feb 2022 22:56:45 GMT, Xue-Lei Andrew Fan wrote:
>> Sorry, you will have to bear with me as I am still not sure how it works - I
>> want to know who wins, the API or the properties, if both are set and I
>> can't find where it answers that above. Maybe I need to read the code. Are
>>
On Mon, 7 Feb 2022 22:18:03 GMT, Sean Mullan wrote:
>> I think lines 714-816/723-725 describe the behavior already.
>>
>> I was hesitate to use "override", as the System Property values and the
>> default signature schemes are not actually overrode. The default signature
>> schemes are still
On Mon, 7 Feb 2022 22:00:21 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 744:
>>
>>> 742: * the {@systemProperty jdk.tls.client.SignatureSchemes} and/or
>>> 743: * {@systemProperty jdk.tls.server.SignatureSchemes} system
>>> prope
On Mon, 7 Feb 2022 19:59:32 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct null tags
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 47:
>
>> 45: *
>> 46: *
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
> Release-note: https://bugs.openjdk.java.net/browse/JDK-8
On Mon, 7 Feb 2022 19:51:28 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> correct null tags
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 744:
>
>> 742: * the
On Fri, 4 Feb 2022 20:58:46 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Fri, 4 Feb 2022 16:35:22 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More update for the sec and impl
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 713:
>
>> 7
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Fri, 4 Feb 2022 16:34:14 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More update for the sec and impl
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 735:
>
>> 7
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Thu, 3 Feb 2022 21:30:59 GMT, Sean Mullan wrote:
> > > On a related issue, have you given any thought as to what the behavior
> > > should be if a 3rd-party JSSE provider is not updated to support these
> > > new methods? I don't know of a good way to address that since the API is
> > > not
On Wed, 2 Feb 2022 22:41:56 GMT, Xue-Lei Andrew Fan wrote:
> > On a related issue, have you given any thought as to what the behavior
> > should be if a 3rd-party JSSE provider is not updated to support these new
> > methods? I don't know of a good way to address that since the API is not
> >
On Wed, 2 Feb 2022 22:13:07 GMT, Sean Mullan wrote:
> On a related issue, have you given any thought as to what the behavior should
> be if a 3rd-party JSSE provider is not updated to support these new methods?
> I don't know of a good way to address that since the API is not part of the
> pro
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Wed, 2 Feb 2022 19:12:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Wed, 2 Feb 2022 14:45:21 GMT, Sean Mullan wrote:
> A few more comments on the API.
All good catches! Thank you very much. Updated the spec, CSR and impl.
-
PR: https://git.openjdk.java.net/jdk/pull/7252
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Tue, 1 Feb 2022 06:42:30 GMT, Xue-Lei Andrew Fan wrote:
>> Ok. You should specify what the default value of the signature schemes
>> parameter is for this constructor as it does for the other parameters.
>
> Good catch. Updated.
Looks good.
-
PR: https://git.openjdk.java.net/j
On Tue, 1 Feb 2022 06:47:00 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-8
On Mon, 31 Jan 2022 21:55:18 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rollback to use captialized S
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 727:
>
>> 725
On Mon, 31 Jan 2022 21:26:46 GMT, Sean Mullan wrote:
>> As there is increasing number of SSL parameters, applications may just use
>> the constructor with no argument, and use the set methods individually.
>
> Ok. You should specify what the default value of the signature schemes
> parameter is
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Sat, 29 Jan 2022 05:26:33 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 94:
>>
>>> 92:
>>> 93: /**
>>> 94: * Constructs SSLParameters.
>>
>> Would it be useful to add another ctor that takes a signature schemes array
>> paramet
On Mon, 31 Jan 2022 20:24:47 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Sun, 30 Jan 2022 03:08:22 GMT, Bernd wrote:
>> Yes, it does. Do you like to use a for-loop, without new object allocation?
>
> Yes, static helper
Thanks for confirm. Updated to use a static helper method.
-
PR: https://git.openjdk.java.net/jdk/pull/7252
On Sun, 30 Jan 2022 03:06:35 GMT, Bernd wrote:
>> Yes. Array copy is a concern of mine, too. Hopefully, the frozen array
>> feature could help address the array copy issues in the future.
>
> Hmm.. I guess the different packages make it really hard to have an internal
> optimized getter. What
On Sun, 30 Jan 2022 03:03:37 GMT, Bernd wrote:
>> If we want to reuse the result, we may have to cache something. It is not
>> good to me. The parsing of the signature scheme names actually depends on
>> the provider. So at this point, in the Java SE API specification, it is not
>> easy to
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Sat, 29 Jan 2022 05:31:08 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 763:
>>
>>> 761:
>>> 762: String[] tempSchemes = signatureSchemes.clone();
>>> 763: for (String scheme : tempSchemes) {
>>
>> In addition to this loo
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Fri, 28 Jan 2022 01:05:22 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Enrich the APIs specification
>
> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 410:
>
>> 408
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Fri, 28 Jan 2022 00:58:37 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 763:
>
>> 761:
>> 762:
On Fri, 28 Jan 2022 15:26:56 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 94:
>
>> 92:
>> 93:
On Fri, 28 Jan 2022 00:54:53 GMT, Bernd wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 92:
>
>> 90: private int
On Fri, 28 Jan 2022 15:50:49 GMT, Jamil Nimeh wrote:
>> You should also define the interaction with the system properties (probably
>> as an @implNote). Does `getSignatureSchemes` ever return the value of the
>> system properties? Does the `setSignatureSchemes` API always override the
>> prope
On Fri, 28 Jan 2022 15:17:25 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 709:
>
>> 707: *
On Fri, 28 Jan 2022 15:44:16 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 710:
>>
>>> 708: * Signature Schemes section of the Java Cryptography
>>> 709: * Architecture Standard Algorithm Name Documentation, and may also
>>> 710: * in
On Fri, 28 Jan 2022 15:17:28 GMT, Sean Mullan wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 710:
>
>> 708: *
On Fri, 28 Jan 2022 07:21:56 GMT, Xue-Lei Andrew Fan wrote:
>> This update is to support signature schemes customization for individual
>> (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
>> RFE: https://bugs.openjdk.java.net/browse/JDK-
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
Xue-Lei Andrew Fan has updated the pull request increment
On Thu, 27 Jan 2022 23:43:51 GMT, Jie Fu wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyright correction
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 3:
>
>> 1: /*
>> 2: * Copy
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote:
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280
On Thu, 27 Jan 2022 22:06:21 GMT, Xue-Lei Andrew Fan wrote:
> This update is to support signature schemes customization for individual
> (D)TLS connection. Please review the CSR as well:
> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
> RFE: https://bugs.openjdk.java.net/browse/JDK-8280
This update is to support signature schemes customization for individual (D)TLS
connection. Please review the CSR as well:
CSR: https://bugs.openjdk.java.net/browse/JDK-8280495
RFE: https://bugs.openjdk.java.net/browse/JDK-8280494
-
Commit messages:
- 8280494: https://bugs.openjdk.
70 matches
Mail list logo
