Re: RFR: 8280414: Memory leak in DefaultProxySelector

2022-01-21 Thread Daniel Jeliński
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote: > We were leaking the list returned by `createProxyList`. Verified that the > leak is no longer present with this patch. Also removed a few unused > variables. > > Reported by clang-tidy. Thanks for reviewing! - PR: https:

Re: RFR: 8280414: Memory leak in DefaultProxySelector

2022-01-21 Thread Daniel Fuchs
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote: > We were leaking the list returned by `createProxyList`. Verified that the > leak is no longer present with this patch. Also removed a few unused > variables. > > Reported by clang-tidy. Marked as reviewed by dfuchs (Reviewer). --

Re: RFR: 8280414: Memory leak in DefaultProxySelector

2022-01-21 Thread Daniel Jeliński
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote: > We were leaking the list returned by `createProxyList`. Verified that the > leak is no longer present with this patch. Also removed a few unused > variables. > > Reported by clang-tidy. tier1 and tier2 also passed. - PR:

Re: RFR: 8280414: Memory leak in DefaultProxySelector

2022-01-21 Thread Daniel Jeliński
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote: > We were leaking the list returned by `createProxyList`. Verified that the > leak is no longer present with this patch. Also removed a few unused > variables. > > Reported by clang-tidy. Tested locally. Returned values look correct, an

Re: RFR: 8280414: Memory leak in DefaultProxySelector

2022-01-21 Thread Daniel Fuchs
On Fri, 21 Jan 2022 08:25:30 GMT, Daniel Jeliński wrote: > We were leaking the list returned by `createProxyList`. Verified that the > leak is no longer present with this patch. Also removed a few unused > variables. > > Reported by clang-tidy. Look reasonable to me. Did you run tier1 - tier2

RFR: 8280414: Memory leak in DefaultProxySelector

2022-01-21 Thread Daniel Jeliński
We were leaking the list returned by `createProxyList`. Verified that the leak is no longer present with this patch. Also removed a few unused variables. Reported by clang-tidy. - Commit messages: - Fix memory leak Changes: https://git.openjdk.java.net/jdk/pull/7172/files Webrev: