Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-14 Thread Michael McMahon
On Thu, 13 Jan 2022 15:39:28 GMT, Julia Boes wrote: >> This new test confirms that the jwebserver does not wait indefinitely for a >> request to arrive, but instead closes the connection when the maximum >> request time is reached. To facilitate this, Exchange::run is amended to >> process can

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-14 Thread Daniel Fuchs
On Thu, 13 Jan 2022 15:39:28 GMT, Julia Boes wrote: >> This new test confirms that the jwebserver does not wait indefinitely for a >> request to arrive, but instead closes the connection when the maximum >> request time is reached. To facilitate this, Exchange::run is amended to >> process can

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-13 Thread Jaikiran Pai
Thank you Julia, these new changes look fine to me. -Jaikiran On 13/01/22 9:09 pm, Julia Boes wrote: On Thu, 13 Jan 2022 04:52:25 GMT, Jaikiran Pai wrote: Julia Boes has updated the pull request incrementally with one additional commit since the last revision: address PR comments: *

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-13 Thread Julia Boes
On Thu, 13 Jan 2022 04:52:25 GMT, Jaikiran Pai wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address PR comments: >> * remove redundant null check >> * use try-finally to stop process in test > > src/jdk.httpse

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time [v2]

2022-01-13 Thread Julia Boes
> This new test confirms that the jwebserver does not wait indefinitely for a > request to arrive, but instead closes the connection when the maximum request > time is reached. To facilitate this, Exchange::run is amended to process > cancelled keys in the case where the current thread is the di

Re: RFR: 8278398: jwebserver: Add test to confirm maximum request time

2022-01-12 Thread Jaikiran Pai
On Wed, 12 Jan 2022 16:59:14 GMT, Julia Boes wrote: > This new test confirms that the jwebserver does not wait indefinitely for a > request to arrive, but instead closes the connection when the maximum request > time is reached. To facilitate this, Exchange::run is amended to process > cancell

RFR: 8278398: jwebserver: Add test to confirm maximum request time

2022-01-12 Thread Julia Boes
This new test confirms that the jwebserver does not wait indefinitely for a request to arrive, but instead closes the connection when the maximum request time is reached. To facilitate this, Exchange::run is amended to process cancelled keys in the case where the current thread is the dispatcher