Re: RFR: 8276798: HttpURLConnection sends invalid HTTP request

2022-06-08 Thread Daniel Fuchs
On Mon, 6 Jun 2022 09:43:50 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix > https://bugs.openjdk.java.net/browse/JDK-8276798? > > `sun.net.www.protocol.http.HttpURLConnection` has a (private) `writeRequests` > method. This method is responsible for c

Re: RFR: 8276798: HttpURLConnection sends invalid HTTP request

2022-06-07 Thread Jaikiran Pai
On Mon, 6 Jun 2022 09:43:50 GMT, Jaikiran Pai wrote: > tier1, tier2 and tier3 tests have passed without issues. Additionally, the reproducer attached to the JBS issue has been run locally. The test fails regularly without this change and hasn't failed even once after this change. ---

RFR: 8276798: HttpURLConnection sends invalid HTTP request

2022-06-06 Thread Jaikiran Pai
Can I please get a review of this change which proposes to fix https://bugs.openjdk.java.net/browse/JDK-8276798? `sun.net.www.protocol.http.HttpURLConnection` has a (private) `writeRequests` method. This method is responsible for creating the standard HTTP request headers (include the request l