On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by jrose (Re
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by lancea (R
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by iris (Rev
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by rriggs (R
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
LGTM
-
Marked as
> 8273616: Fix trivial doc typos in the java.base module
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Use "ensure" instead of "insure"
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5475/files
- new: https
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Thanks to those who reviewed this PR. Since I p
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Marked as reviewed by lancea (Reviewer).
-
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Marked as reviewed by iris (Reviewer).
---
> 8273616: Fix trivial doc typos in the java.base module
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Revert two fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5475/files
- new: https://git.openjdk.j
On Fri, 10 Sep 2021 21:52:36 GMT, John R Rose wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert two fixes
>
> src/java.base/share/classes/java/nio/channels/FileChannel.java line 567:
>
>> 565: *
On Fri, 10 Sep 2021 21:51:45 GMT, John R Rose wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java
> line 399:
>
>> 397: * If {@code true} then this method is required to force
>> changes
>
On Fri, 10 Sep 2021 21:16:19 GMT, Pavel Rappo wrote:
> 8273616: Fix trivial doc typos in the java.base module
Approved, except for two changes commented above: the original "it need only
force" is correct usage, and "it needs only force" is not good usage, but "it
only needs to force" would be
8273616: Fix trivial doc typos in the java.base module
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.java.net/jdk/pull/5475/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5475&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8273616
Stats
14 matches
Mail list logo
