On Wed, 4 Aug 2021 15:11:59 GMT, Daniel Fuchs wrote:
>> Have a marginal preference for HttpConnection.class.getSimpleName(), since
>> it is a constant, but don't object to getClass().
>
> Right - but then why not use a string literal? If you're going to call a
> method to get the class name the
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote:
> This is a minor change that updates
> `sun.net.httpserver.HttpConnection::toString` to never return null.
>
> Testing: tier 1-3 all clear
Looks good.
-
Marked as reviewed by vtewari (Committer).
PR: https://git.openjdk.java.n
On Wed, 4 Aug 2021 12:43:43 GMT, Chris Hegarty wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/HttpConnection.java line
>> 69:
>>
>>> 67:
>>> 68: public String toString() {
>>> 69: final var sb = new
>>> StringBuilder(HttpConnection.class.getSimpleName());
>>
>> Why
On Wed, 4 Aug 2021 10:54:10 GMT, Daniel Fuchs wrote:
>> This is a minor change that updates
>> `sun.net.httpserver.HttpConnection::toString` to never return null.
>>
>> Testing: tier 1-3 all clear
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/HttpConnection.java line
> 69:
>
>> 67:
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote:
> This is a minor change that updates
> `sun.net.httpserver.HttpConnection::toString` to never return null.
>
> Testing: tier 1-3 all clear
Marked as reviewed by chegar (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/492
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote:
> This is a minor change that updates
> `sun.net.httpserver.HttpConnection::toString` to never return null.
>
> Testing: tier 1-3 all clear
src/jdk.httpserver/share/classes/sun/net/httpserver/HttpConnection.java line 69:
> 67:
> 68: pub
This is a minor change that updates
`sun.net.httpserver.HttpConnection::toString` to never return null.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.java.net/jdk/pull/4928/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4928&range=00
Issue: https:
