On Wed, 7 Apr 2021 17:07:44 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> assign unmodHeaders instead of original headers
>
> Marked as reviewed by dfuchs (Reviewer).
Latest changes LGTM.
--
On Wed, 7 Apr 2021 17:02:28 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> as
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
assign unmodHeaders instead of original headers
-
Ch
On Wed, 7 Apr 2021 13:28:32 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev e
On Tue, 6 Apr 2021 13:12:46 GMT, Julia Boes wrote:
>> LGTM
>
> I included a null check in the constructor to account for null values of
> `List`, which `Headers` allows. Fixed the indentation.
>
> Testing: Tier 1-3 all clear.
It turns out I wasn't right in the last commit. The null check is no
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebas
On Tue, 6 Apr 2021 13:10:59 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev e
On Thu, 1 Apr 2021 14:08:47 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move constructor call in ExchangeImpl and fix indentation
>
> LGTM
I included a null check in the constructor to accou
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Julia Boes has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebas
On Wed, 31 Mar 2021 10:51:40 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> m
On Wed, 31 Mar 2021 10:51:40 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> m
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
move constructor call in ExchangeImpl and fix indentation
---
On Mon, 29 Mar 2021 09:09:00 GMT, Julia Boes wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> Julia Boes has updated the pull request incrementally with two additional
> commits since the last revision:
>
> -
On Tue, 16 Mar 2021 14:35:12 GMT, Michael McMahon wrote:
>> Julia Boes has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - wrap List with unmodifiable map and update test
>> - remove map wrapping
>
> Changes requested by michaelm (Reviewe
On Mon, 22 Mar 2021 16:41:10 GMT, Daniel Fuchs wrote:
>> Actually, I just noticed that the `List`s are still modifiable. The
>> constructor might have to create an intermediate `Map>`
>> with unmodifiable Lists and then you create an unmodifiable Map from that.
>>
>> As regards the comment ab
On Mon, 22 Mar 2021 16:36:55 GMT, Daniel Fuchs wrote:
>> I guess this presumes that no reference to `headers` escapes? Can that be
>> assumed?
>
> Yes - it's private - and that wasn't a problem before - was it? The problem
> was the put method that still put things into the map - and that will
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Julia Boes has updated the pull request incrementally with two additional
commits since the last revision:
- wrap List with unmodifiable map and update test
- remove map wr
On Mon, 22 Mar 2021 16:25:24 GMT, Michael McMahon wrote:
>> Headers normalizes the key before any get/getFirst, for example Headers line
>> 131:
>>
>> `public List get(Object key) {
>> return map.get(normalize((String)key));
>> }`
>>
>> I assume we want to maintain this beh
On Mon, 22 Mar 2021 16:30:10 GMT, Michael McMahon wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
>> line 34:
>>
>>> 32: public class UnmodifiableHeaders extends Headers {
>>> 33:
>>> 34: private Map> map;
>>
>> How about:
>>
>> private final He
On Tue, 16 Mar 2021 14:19:09 GMT, Julia Boes wrote:
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
line 34:
> 32: public class UnmodifiableHea
On Mon, 22 Mar 2021 11:56:58 GMT, Julia Boes wrote:
>> src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
>> line 60:
>>
>>> 58: map.forEach((k, v) -> headers.add(k, v.get(0)));
>>> 59: return headers.getFirst(key);
>>> 60: }
>>
>> Shou
On Mon, 22 Mar 2021 16:23:27 GMT, Daniel Fuchs wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
> line 34:
>
>> 32: public class Unm
The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable by
wrapping it in an unmodifiable view.
-
Commit messages:
- fix imports
- Merge branch 'master' into 8263506
- fix UnmodifiableHeaders impl
- add initial test
Changes: https://git.openjdk.java.net/jdk/
On Tue, 16 Mar 2021 14:30:39 GMT, Michael McMahon wrote:
>> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
>> by wrapping it in an unmodifiable view.
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
> line 60:
>
>> 58: m
On Tue, 16 Mar 2021 14:19:09 GMT, Julia Boes wrote:
> The fix makes the map in sun.net.httpserver.UnmodifiableHeaders unmodifiable
> by wrapping it in an unmodifiable view.
Changes requested by michaelm (Reviewer).
src/jdk.httpserver/share/classes/sun/net/httpserver/UnmodifiableHeaders.java
l
25 matches
Mail list logo
