Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v4]

2021-03-23 Thread Michael McMahon
> Hi, > > The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of > regression failures, which turned out to be another bug exposed by this fix > where HTTP/1.1 CONNECT requests with authentication were filtering out proxy > authentication headers wrongly. This was because t

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v3]

2021-03-23 Thread Michael McMahon
On Tue, 23 Mar 2021 11:06:16 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated test to test proxy authorization > > test/jdk/java/net/httpclient/AuthFilter.java line 145: > >> 143:

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v3]

2021-03-23 Thread Daniel Fuchs
On Mon, 22 Mar 2021 22:13:12 GMT, Michael McMahon wrote: >> What I am seeing is that if no authenticator set, whether the fix is present >> or not, an "Authorization" header is passed through, but a >> "Proxy-Authorization" header is filtered. So, that is a different issue. It >> probably is a

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v3]

2021-03-23 Thread Daniel Fuchs
On Mon, 22 Mar 2021 22:16:09 GMT, Michael McMahon wrote: >> Hi, >> >> The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of >> regression failures, which turned out to be another bug exposed by this fix >> where HTTP/1.1 CONNECT requests with authentication were filtering

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v3]

2021-03-22 Thread Michael McMahon
On Mon, 15 Mar 2021 14:57:33 GMT, Michael McMahon wrote: >> test/jdk/java/net/httpclient/AuthFilter.java line 57: >> >>> 55: Headers reqh = e.getRequestHeaders(); >>> 56: if (reqh.containsKey("authorization")) { >>> 57: e.sendResponseHeaders(500, -1); >>

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v3]

2021-03-22 Thread Michael McMahon
> Hi, > > The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of > regression failures, which turned out to be another bug exposed by this fix > where HTTP/1.1 CONNECT requests with authentication were filtering out proxy > authentication headers wrongly. This was because t

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v2]

2021-03-18 Thread Michael McMahon
> Hi, > > The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of > regression failures, which turned out to be another bug exposed by this fix > where HTTP/1.1 CONNECT requests with authentication were filtering out proxy > authentication headers wrongly. This was because t

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED

2021-03-15 Thread Michael McMahon
On Mon, 15 Mar 2021 13:21:25 GMT, Daniel Fuchs wrote: >> Hi, >> >> The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of >> regression failures, which turned out to be another bug exposed by this fix >> where HTTP/1.1 CONNECT requests with authentication were filtering ou

Re: RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED

2021-03-15 Thread Daniel Fuchs
On Fri, 12 Mar 2021 21:04:59 GMT, Michael McMahon wrote: > Hi, > > The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of > regression failures, which turned out to be another bug exposed by this fix > where HTTP/1.1 CONNECT requests with authentication were filtering out

RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED

2021-03-12 Thread Michael McMahon
Hi, The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of regression failures, which turned out to be another bug exposed by this fix where HTTP/1.1 CONNECT requests with authentication were filtering out proxy authentication headers wrongly. This was because the HttpReque