Re: RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

2021-10-18 Thread Daniel Fuchs
On Tue, 12 Oct 2021 15:41:30 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my changes (and CSR) to drop support for pre JDK >> 1.4 `DatagramSocketImpl` implementations? >> >> These changes propose to drop support for `DatagramSocketImpls` that were >> compiled with J

Re: RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

2021-10-12 Thread Alan Bateman
On Tue, 12 Oct 2021 15:41:30 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my changes (and CSR) to drop support for pre JDK >> 1.4 `DatagramSocketImpl` implementations? >> >> These changes propose to drop support for `DatagramSocketImpls` that were >> compiled with J

Re: RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

2021-10-12 Thread Patrick Concannon
On Tue, 12 Oct 2021 11:15:55 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/net/DatagramSocketImpl.java line 105: >> >>> 103: * >>> 104: * @implSpec the default implementation of this method always >>> throws {@code SocketException} >>> 105: * >> >> The implementat

Re: RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

2021-10-12 Thread Patrick Concannon
On Tue, 12 Oct 2021 11:20:01 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> c

Re: RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

2021-10-12 Thread Patrick Concannon
On Tue, 12 Oct 2021 07:10:56 GMT, Vyom Tewari wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> co

Re: RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

2021-10-12 Thread Patrick Concannon
> Hi, > > Could someone please review my changes (and CSR) to drop support for pre JDK > 1.4 `DatagramSocketImpl` implementations? > > These changes propose to drop support for `DatagramSocketImpls` that were > compiled with JDK 1.3 or older, which do not have support for connected > sockets,