Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-27 Thread Daniel Fuchs
On Mon, 26 Oct 2020 14:29:00 GMT, Igor Ignatyev wrote: >> src/java.base/share/classes/sun/net/ftp/impl/FtpClient.java line 1777: >> >>> 1775: } >>> 1776: >>> 1777: private static Date parseRfc3659TimeValue(String s) { >> >> Shouldn't this method be synchronized because `SimpleDateForma

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-26 Thread Igor Ignatyev
On Sun, 25 Oct 2020 00:35:20 GMT, Marcono1234 wrote: >> Igor Ignatyev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use only filename in assert message > > src/java.base/share/classes/sun/net/ftp/impl/FtpClient.java line 1777: > >> 1

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-24 Thread Marcono1234
On Fri, 23 Oct 2020 17:50:51 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this small patch? >> >> according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in >> MLSx response have the following format: >>>time-val = 14DIGIT [ "." 1*DIGIT ] >>> >>>

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-23 Thread Igor Ignatyev
On Fri, 23 Oct 2020 18:05:07 GMT, Daniel Fuchs wrote: >> Igor Ignatyev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use only filename in assert message > > Thanks for adding a test Igor! > If that passes on all platform then this look

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-23 Thread Daniel Fuchs
On Fri, 23 Oct 2020 17:50:51 GMT, Igor Ignatyev wrote: >> Hi all, >> >> could you please review this small patch? >> >> according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in >> MLSx response have the following format: >>>time-val = 14DIGIT [ "." 1*DIGIT ] >>> >>>

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v3]

2020-10-23 Thread Igor Ignatyev
> Hi all, > > could you please review this small patch? > > according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in > MLSx response have the following format: >>time-val = 14DIGIT [ "." 1*DIGIT ] >> >>The leading, mandatory, fourteen digits are to be interpreted as

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format

2020-10-23 Thread Igor Ignatyev
On Thu, 22 Oct 2020 16:04:56 GMT, Igor Ignatyev wrote: >> Hi Igor, is this testable - and if so shouldn't there be a test? >> best regards, >> -- daniel > >> Hi Igor, is this testable - and if so shouldn't there be a test? >> best regards, >> -- daniel > > Hi Daniel, > > it's testable and origi

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format [v2]

2020-10-23 Thread Igor Ignatyev
> Hi all, > > could you please review this small patch? > > according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in > MLSx response have the following format: >>time-val = 14DIGIT [ "." 1*DIGIT ] >> >>The leading, mandatory, fourteen digits are to be interpreted as

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format

2020-10-22 Thread Igor Ignatyev
On Thu, 22 Oct 2020 10:33:06 GMT, Daniel Fuchs wrote: > Hi Igor, is this testable - and if so shouldn't there be a test? > best regards, > -- daniel Hi Daniel, it's testable and originally I planned to add a new test, however upon checking the existing mock ftp-servers, I realized that none of

Re: RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format

2020-10-22 Thread Daniel Fuchs
On Tue, 20 Oct 2020 23:14:40 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this small patch? > > according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in > MLSx response have the following format: >>time-val = 14DIGIT [ "." 1*DIGIT ] >> >>The lea

RFR: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format

2020-10-20 Thread Igor Ignatyev
Hi all, could you please review this small patch? according to [RFC3659](https://tools.ietf.org/html/rfc3659), time values in MLSx response have the following format: >time-val = 14DIGIT [ "." 1*DIGIT ] > >The leading, mandatory, fourteen digits are to be interpreted as, in >order f