Re: RFR: 8254996: make jdk.net.UnixDomainPrincipal a record class [v3]

2020-12-09 Thread Patrick Concannon
> Hi, > > Could someone please review my code for JDK-8254996: 'make > jdk.net.UnixDomainPrincipal a record class'? > > `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires > boilerplate methods for access. However, these methods and fields are > susceptible to trivial

Re: RFR: 8254996: make jdk.net.UnixDomainPrincipal a record class [v2]

2020-12-09 Thread Patrick Concannon
> Hi, > > Could someone please review my code for JDK-8254996: 'make > jdk.net.UnixDomainPrincipal a record class'? > > `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires > boilerplate methods for access. However, these methods and fields are > susceptible to trivial

Re: RFR: 8254996: make jdk.net.UnixDomainPrincipal a record class

2020-12-07 Thread Michael McMahon
On Mon, 7 Dec 2020 15:32:54 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for JDK-8254996: 'make > jdk.net.UnixDomainPrincipal a record class'? > > `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires > boilerplate methods for access. How

Re: RFR: 8254996: make jdk.net.UnixDomainPrincipal a record class

2020-12-07 Thread Daniel Fuchs
On Mon, 7 Dec 2020 15:32:54 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for JDK-8254996: 'make > jdk.net.UnixDomainPrincipal a record class'? > > `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires > boilerplate methods for access. How

RFR: 8254996: make jdk.net.UnixDomainPrincipal a record class

2020-12-07 Thread Patrick Concannon
Hi, Could someone please review my code for JDK-8254996: 'make jdk.net.UnixDomainPrincipal a record class'? `jdk.net.UnixDomainPrincipal` is a simple immutable data class that requires boilerplate methods for access. However, these methods and fields are susceptible to trivial mistakes and add