Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-15 Thread Michael McMahon
On Mon, 14 Mar 2022 13:21:21 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java >> line 155: >> >>> 153: boolean offerConnection(Http2Connection c) { >>> 154: if (debug.on()) debug.log("offering to the connection pool: >>> %s", c)

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-15 Thread Michael McMahon
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created, and

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-14 Thread Daniel Fuchs
On Mon, 14 Mar 2022 10:04:13 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Copyright years > > src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java > line 155: > >> 15

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-14 Thread Michael McMahon
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created, and

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-11 Thread Jaikiran Pai
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created, and

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-11 Thread Daniel Fuchs
On Fri, 11 Mar 2022 10:33:09 GMT, Jaikiran Pai wrote: >> I'm not completely sure of the purpose of the synchronized block here - but >> I'd rather not change this in this PR (and I'd rather not change it at all >> unless it proves to cause issues). As for the second check for isOpen() - I >> i

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-11 Thread Jaikiran Pai
On Fri, 11 Mar 2022 10:07:21 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java >> line 162: >> >>> 160: >>> 161: String key = c.key(); >>> 162: synchronized(this) { >> >> Hello Daniel, it's not fully clear to me why this syn

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-11 Thread Jaikiran Pai
On Fri, 11 Mar 2022 10:12:46 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java >> line 170: >> >>> 168: Http2Connection c1 = connections.putIfAbsent(key, c); >>> 169: if (c1 != null) { >>> 170: c.setFin

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-11 Thread Daniel Fuchs
On Fri, 11 Mar 2022 05:28:36 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Copyright years > > src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java > line 162: > >> 160:

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-10 Thread Jaikiran Pai
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created, and

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-10 Thread Jaikiran Pai
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch that solves an intermittent issue detected by >> the CancelRequestTest.java >> >> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled >> after the Http2Connection has been created, and

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v3]

2022-03-10 Thread Daniel Fuchs
> Please find enclosed a patch that solves an intermittent issue detected by > the CancelRequestTest.java > > If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled > after the Http2Connection has been created, and the handshake has proceeded, > and the response headers to

Re: RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently [v2]

2022-03-10 Thread Daniel Fuchs
> Please find enclosed a patch that solves an intermittent issue detected by > the CancelRequestTest.java > > If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled > after the Http2Connection has been created, and the handshake has proceeded, > and the response headers to

RFR: 8254786: java/net/httpclient/CancelRequestTest.java failing intermittently

2022-03-10 Thread Daniel Fuchs
Please find enclosed a patch that solves an intermittent issue detected by the CancelRequestTest.java If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled after the Http2Connection has been created the handshake has proceeded, and the response headers to the upgrade have