Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-06 Thread Conor Cleary
On Tue, 6 Oct 2020 17:04:01 GMT, Aleksey Shipilev wrote: > I can sponsor this, but it is not clear what testing was done on this. At > least `tier1`? `tier1`, `tier2`, `jdk_net`, `test/jdk/java/net/httpclient` tests were conducted with all passing. - PR: https://git.openjdk.java.

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-06 Thread Aleksey Shipilev
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/browse/

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-06 Thread Aleksey Shipilev
On Tue, 6 Oct 2020 17:02:37 GMT, Aleksey Shipilev wrote: >> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8253179: Removed ArrayList copy of streams > > Marked as reviewed by shade (Reviewer). I can sponsor this, but it i

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-06 Thread Chris Hegarty
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/browse/

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-06 Thread Pavel Rappo
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/browse/

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-06 Thread Daniel Fuchs
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/browse/

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-02 Thread Conor Cleary
On Fri, 2 Oct 2020 08:41:56 GMT, Conor Cleary wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/browse/

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection [v2]

2020-10-02 Thread Conor Cleary
> This patch replaces a LinkedList data structure used in the > net.http.Http2Connection class with an ArrayList. This > issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in > java.net](https://bugs.openjdk.java.net/browse/JDK-8246048). Some > justifications for this change are a

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 10:38:43 GMT, Pavel Rappo wrote: >> Taking a look at this presently > > Although Aleksey's proposal does not change the behavior, it raises a > question (to be explored separately): can a > stream be added to that map while `Http2Connection.shutdown` is in progress? > If this

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Pavel Rappo
On Thu, 1 Oct 2020 10:31:58 GMT, Conor Cleary wrote: >> Good point Aleksey. I guess that the original intent was to avoid >> `ConcurrentModificationException`. However I see that >> `streams` is a `ConcurrentHashMap` now. So maybe we could dispense of the >> copy: >> `private final Map> str

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Conor Cleary
On Thu, 1 Oct 2020 09:43:46 GMT, Daniel Fuchs wrote: >> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java >> line 703: >> >>> 701: if (initialCause == null) this.cause = t; >>> 702: client2.deleteConnection(this); >>> 703: List> c = new ArrayList

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Daniel Fuchs
On Thu, 1 Oct 2020 08:22:35 GMT, Aleksey Shipilev wrote: >> This patch replaces a LinkedList data structure used in the >> net.http.Http2Connection class with an ArrayList. This >> issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in >> java.net](https://bugs.openjdk.java.net/bro

Re: RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Aleksey Shipilev
On Wed, 30 Sep 2020 10:22:11 GMT, Conor Cleary wrote: > This patch replaces a LinkedList data structure used in the > net.http.Http2Connection class with an ArrayList. This > issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in > java.net](https://bugs.openjdk.java.net/browse/JDK

RFR: 8253179: Replace LinkedList Impl in net.http.Http2Connection

2020-10-01 Thread Conor Cleary
This patch replaces a LinkedList data structure used in the net.http.Http2Connection class with an ArrayList. This issue relates to [JDK-8246048: Replace LinkedList with ArrayLists in java.net](https://bugs.openjdk.java.net/browse/JDK-8246048). Some justifications for this change are as follows: