Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v3]

2021-03-01 Thread Daniel Fuchs
On Sat, 27 Feb 2021 10:04:28 GMT, Alan Bateman wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed @throws to conform to the style of other @throws in java.net.URI > > Looks fine, just a few formatting nits. Tha

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v5]

2021-03-01 Thread Daniel Fuchs
> Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Fixed trailing whitespaces - Changes:

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v4]

2021-03-01 Thread Daniel Fuchs
> Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v3]

2021-02-27 Thread Alan Bateman
On Fri, 26 Feb 2021 10:59:01 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a change that fixes "no comment" warnings generated by >> `javadoc -Xdoclint` for `java.base/java.net` > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v3]

2021-02-26 Thread Naoto Sato
On Fri, 26 Feb 2021 10:59:01 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a change that fixes "no comment" warnings generated by >> `javadoc -Xdoclint` for `java.base/java.net` > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v3]

2021-02-26 Thread Chris Hegarty
On Fri, 26 Feb 2021 10:59:01 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a change that fixes "no comment" warnings generated by >> `javadoc -Xdoclint` for `java.base/java.net` > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v3]

2021-02-26 Thread Daniel Fuchs
> Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Fixed @throws to conform to the style of other @throws

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-26 Thread Conor Cleary
On Fri, 26 Feb 2021 10:44:04 GMT, Rahul Yadav wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > LGTM! Ran the changes through `-Xdoclint:missing` and there were no warnings outputted so looks good

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-26 Thread Rahul Yadav
On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a change that fixes "no comment" warnings generated by >> `javadoc -Xdoclint` for `java.base/java.net` > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Daniel Fuchs
On Thu, 25 Feb 2021 16:59:07 GMT, Naoto Sato wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > src/java.base/share/classes/java/net/InetSocketAddress.java line 326: > >> 324: /** >> 325: *

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Naoto Sato
On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a change that fixes "no comment" warnings generated by >> `javadoc -Xdoclint` for `java.base/java.net` > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last re

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net

2021-02-25 Thread Daniel Fuchs
On Wed, 24 Feb 2021 20:42:52 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` The CSR draft can be reviewed here: https://bugs.openjdk.java.net/browse/JDK-8262372 - PR: https

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Daniel Fuchs
> Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Fixed comment - Changes: - all: https:

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]

2021-02-25 Thread Daniel Fuchs
On Thu, 25 Feb 2021 09:24:50 GMT, Patrick Concannon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > src/java.base/share/classes/java/net/HttpRetryException.java line 48: > >> 46: >> 47: /**

Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net

2021-02-25 Thread Patrick Concannon
On Wed, 24 Feb 2021 20:42:52 GMT, Daniel Fuchs wrote: > Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` src/java.base/share/classes/java/net/HttpRetryException.java line 48: > 46: > 47: /** > 48: * the U

RFR: 8253100: Fix "no comment" warnings in java.base/java.net

2021-02-24 Thread Daniel Fuchs
Hi, Please find here a change that fixes "no comment" warnings generated by `javadoc -Xdoclint` for `java.base/java.net` - Commit messages: - Fixed trailing whitespace - 8253100: Fix "no comment" warnings in java.base/java.net Changes: https://git.openjdk.java.net/jdk/pull/2715/