On Tue, 17 Nov 2020 16:50:46 GMT, Daniel Fuchs wrote:
>> Would it be enough to check in each test case that if we are examining a
>> request with headers, it contains at least one called `testName1`? i.e.
>> if(!request.headers().map().isEmpty())
>> assertTrue(request.headers
On Tue, 17 Nov 2020 18:28:46 GMT, Daniel Fuchs wrote:
>> Ah! Good catch - I believe the code is buggy. It should have been
>> `!name.equalsIgnoreCase(...)`.
>
> Patrick - can you add a test case with exactly **that** use case? I know you
> have similar tests which remove `"testName1"`, but it w
On Mon, 16 Nov 2020 17:23:42 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> comm
On Tue, 17 Nov 2020 17:28:45 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/java/net/http/HttpRequest.java line 335:
>>
>>> 333: * Remove a particular header (e.g. Foo-Bar):
>>> 334: * {@code HttpRequest.newBuilder(request, (name, value) ->
>>> name.equalsIgnoreCase("F
On Tue, 17 Nov 2020 17:16:48 GMT, Michael McMahon wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> c
On Mon, 16 Nov 2020 15:54:18 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
On Mon, 16 Nov 2020 15:54:18 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
On Tue, 17 Nov 2020 16:16:53 GMT, Patrick Concannon
wrote:
>> test/jdk/java/net/httpclient/HttpRequestNewBuilderTest.java line 320:
>>
>>> 318: @Test(dataProvider = "testRequests")
>>> 319: public void testRemoveHeader(HttpRequest request) {
>>> 320: BiPredicate filter = (n, v)
On Mon, 16 Nov 2020 17:29:20 GMT, Daniel Fuchs wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> comm
On Mon, 16 Nov 2020 15:54:18 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review our code for JDK-8252304: 'Seed an
>> HttpRequest.Builder from an existing HttpRequest'?
>>
>> This RFR proposes a new factory method for creating a new `HttpRequest`
>> builder from an existi
> Hi,
>
> Could someone please review our code for JDK-8252304: 'Seed an
> HttpRequest.Builder from an existing HttpRequest'?
>
> This RFR proposes a new factory method for creating a new `HttpRequest`
> builder from an existing `HttpRequest`.
> This method can be used to build a new request eq
11 matches
Mail list logo
