Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v6]

2020-11-16 Thread Patrick Concannon
On Fri, 13 Nov 2020 17:16:21 GMT, Daniel Fuchs wrote: >> test/jdk/java/net/httpclient/HttpRequestNewBuilderTest.java line 171: >> >>> 169: while (iter1.hasNext() && iter2.hasNext()) >>> 170: assertEquals(iter1.next(), iter2.next()); >>> 171: } >> >> This code doesn't see

Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v6]

2020-11-13 Thread Daniel Fuchs
On Fri, 13 Nov 2020 16:45:31 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review our code for JDK-8252304: 'Seed an >> HttpRequest.Builder from an existing HttpRequest'? >> >> This RFR proposes a new factory method for creating a new `HttpRequest` >> builder from an existi

Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v6]

2020-11-13 Thread Daniel Fuchs
On Fri, 13 Nov 2020 17:21:02 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> comm

Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v6]

2020-11-13 Thread Patrick Concannon
> Hi, > > Could someone please review our code for JDK-8252304: 'Seed an > HttpRequest.Builder from an existing HttpRequest'? > > This RFR proposes a new factory method for creating a new `HttpRequest` > builder from an existing `HttpRequest`. > This method can be used to build a new request eq