Re: RFR: 8245194: Unix domain socket channel implementation [v23]

2020-10-15 Thread Michael McMahon
On Wed, 14 Oct 2020 18:37:57 GMT, Daniel Fuchs wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix white space error > > src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 717: > >> 715:

Re: RFR: 8245194: Unix domain socket channel implementation [v23]

2020-10-14 Thread Daniel Fuchs
On Wed, 14 Oct 2020 18:27:32 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon w

Re: RFR: 8245194: Unix domain socket channel implementation [v23]

2020-10-14 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use