Daniel,
> On 13 Jan 2020, at 13:06, Daniel Fuchs wrote:
>
> Hi,
>
> Please find below a fix for:
> 8236859: WebSocket over authenticating proxy fails with NPE
> https://bugs.openjdk.java.net/browse/JDK-8236859
>
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8236859/webrev.00/
There is a lot
On 14/01/2020 18:17, Pavel Rappo wrote:
I think the WebSocket part of the changeset look good to me. I have gone through
the non-WebSocket part of the changes shallowly. I'm not an expert.
Thanks!
Your review is appreciated!
I will wait until Michael or Chris review the rest of the changes.
b
I think the WebSocket part of the changeset look good to me. I have gone through
the non-WebSocket part of the changes shallowly. I'm not an expert.
> On 14 Jan 2020, at 17:59, Daniel Fuchs wrote:
>
> Hi Pavel,
>
> On 14/01/2020 17:54, Pavel Rappo wrote:
>> That changeset applies fine, thanks.
Hi Pavel,
On 14/01/2020 17:54, Pavel Rappo wrote:
That changeset applies fine, thanks.
I was wondering what you had in mind when added OpeningHandshake:225.
Was it for general robustness or you ran into something in particular?
More for general robustness. Sometimes assertion errors are fire
That changeset applies fine, thanks.
I was wondering what you had in mind when added OpeningHandshake:225.
Was it for general robustness or you ran into something in particular?
> On 14 Jan 2020, at 15:36, Daniel Fuchs wrote:
>
> On 14/01/2020 15:14, Daniel Fuchs wrote:
>> I wonder if this was
On 14/01/2020 15:14, Daniel Fuchs wrote:
I wonder if this was causing issue with the import.
(the patch is obtained by hg diff, not hg export)
Yes. Damn. the open.patch generated by webrev renames the files
instead of copying/modifying...
I have added a proper changeset generated with `hg expo
That patch contains the following lines:
--- old/test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java
2020-01-13 13:04:41.0 +
+++ /dev/null 2020-01-13 13:04:41.0 +
--- old/test/jdk/java/net/httpclient/websocket/Support.java 2020-01-13
13:04:44.00
Hi Pavel,
That's strange. Are you sure your hg import worked properly?
Note that SecureSupport is a modified copy of Support
(not a rename) and DummySecureWebSocketServer is a
modified copy of DummyWebSocketServer (not a rename).
I wonder if this was causing issue with the import.
(the patch is
Daniel,
I imported the patch from the link you provided as follows:
hg import --no-commit open.patch
The patch applied successfully. I tried then to run the tests and saw that some
of them could not be compiled. For instance,
java/net/httpclient/websocket/BlowupOutputQueue.java
java
Hi,
Please find below a fix for:
8236859: WebSocket over authenticating proxy fails with NPE
https://bugs.openjdk.java.net/browse/JDK-8236859
http://cr.openjdk.java.net/~dfuchs/webrev_8236859/webrev.00/
It happens when we have a TLS tunnel and authentication with the server
fails: in that cas
10 matches
Mail list logo
