Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Chris Hegarty
On Fri, 5 Feb 2021 11:25:57 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Daniel Fuchs
On Fri, 5 Feb 2021 11:25:57 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Alan Bateman
On Fri, 5 Feb 2021 11:25:57 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: 8235139: Remove the socket impl factory mechanism [v3]

2021-02-05 Thread Patrick Concannon
> Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically configuring a system-wide factory for the `Socket`, > `ServerSocket`,

Re: RFR: 8235139: Remove the socket impl factory mechanism [v2]

2021-02-04 Thread Daniel Fuchs
On Thu, 4 Feb 2021 15:28:08 GMT, Alan Bateman wrote: > I see you've also added the Deprecated annotation to the private static > fields too. Is this left over from a previous iteration? Humm... Good point! That might not been needed. I believe we experimented with deprecating the XXXSocketFact

Re: RFR: 8235139: Remove the socket impl factory mechanism [v2]

2021-02-04 Thread Alan Bateman
On Thu, 4 Feb 2021 12:18:07 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: 8235139: Remove the socket impl factory mechanism [v2]

2021-02-04 Thread Daniel Fuchs
On Thu, 4 Feb 2021 12:18:07 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically con

Re: RFR: 8235139: Remove the socket impl factory mechanism [v2]

2021-02-04 Thread Patrick Concannon
On Wed, 3 Feb 2021 11:35:07 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> co

Re: RFR: 8235139: Remove the socket impl factory mechanism [v2]

2021-02-04 Thread Patrick Concannon
On Wed, 3 Feb 2021 14:48:15 GMT, Alan Bateman wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> co

Re: RFR: 8235139: Remove the socket impl factory mechanism [v2]

2021-02-04 Thread Patrick Concannon
> Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically configuring a system-wide factory for the `Socket`, > `ServerSocket`,

Re: RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Alan Bateman
On Wed, 3 Feb 2021 11:03:51 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically configurin

Re: RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Daniel Fuchs
On Wed, 3 Feb 2021 11:36:23 GMT, Daniel Fuchs wrote: >> Hi, >> >> Could someone please review my proposed changeset for JDK-8235139: '`Remove >> the socket impl factory mechanism`' ? >> >> These changes propose to deprecate (for the eventual removal) the API points >> for statically configuri

Re: RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Daniel Fuchs
On Wed, 3 Feb 2021 11:03:51 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my proposed changeset for JDK-8235139: '`Remove > the socket impl factory mechanism`' ? > > These changes propose to deprecate (for the eventual removal) the API points > for statically configurin

RFR: 8235139: Remove the socket impl factory mechanism

2021-02-03 Thread Patrick Concannon
Hi, Could someone please review my proposed changeset for JDK-8235139: '`Remove the socket impl factory mechanism`' ? These changes propose to deprecate (for the eventual removal) the API points for statically configuring a system-wide factory for the `Socket`, `ServerSocket`, and `DatagramSoc