Looks good to me Julia!
I will push your changes.
best regards,
-- daniel
On 26/08/2019 12:09, Julia Boes wrote:
Thanks for catching that, Aleksei!
Updated webrev:
http://cr.openjdk.java.net/~dfuchs/jboes/823/webrev.02/index.html
Cheers,
Julia
On 23/08/2019 18:52, Daniel Fuchs wrot
Thanks for catching that, Aleksei!
Updated webrev:
http://cr.openjdk.java.net/~dfuchs/jboes/823/webrev.02/index.html
Cheers,
Julia
On 23/08/2019 18:52, Daniel Fuchs wrote:
Oh! Good catch Aleksei!
In fact all three files are missing the comma.
cheers,
-- daniel
On 23/08/2019 18:47, A
Oh! Good catch Aleksei!
In fact all three files are missing the comma.
cheers,
-- daniel
On 23/08/2019 18:47, Aleks Efimov wrote:
Hi Julia,
Minor comments:
test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java#2:
Could you please add the missing comma after the last modification yea
Hi Julia,
Minor comments:
test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java#2:
Could you please add the missing comma after the last modification year,
i.e. "2018, 2019,"
test/jdk/java/net/httpclient/LineSubscribersAndSurrogatesTest.java#2:
Same stuff: "2018, 2019,"
Otherwise loo
Hi Julia,
Looks good to me too! I will sponsor your change.
best regards,
-- daniel
On 23/08/2019 17:16, Julia Boes wrote:
Hi,
Please find below a fix of three httpclient tests for which testng
trivially passed without running any tests.
In LineSubscribersAndSurrogatesTest and LineStreams
> On 23 Aug 2019, at 17:16, Julia Boes wrote:
> ….
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-823
>
> Webrev: http://cr.openjdk.java.net/~dfuchs/jboes/823/webrev.01/
LGTM.
-Chris.
Hi,
Please find below a fix of three httpclient tests for which testng
trivially passed without running any tests.
In LineSubscribersAndSurrogatesTest and LineStreamsAndSurrogatesTest,
the access modifier of the methods in question was changed to public.
For AbstractThrowingPushPromises, th
