Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v3]

2020-10-13 Thread Michael McMahon
On Mon, 12 Oct 2020 13:50:30 GMT, Daniel Fuchs wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> n

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v3]

2020-10-13 Thread Chris Hegarty
On Mon, 12 Oct 2020 13:50:30 GMT, Daniel Fuchs wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> n

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v3]

2020-10-12 Thread Alan Bateman
On Mon, 12 Oct 2020 13:50:30 GMT, Daniel Fuchs wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> n

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v3]

2020-10-12 Thread Daniel Fuchs
> Hi, > > This is a fix that upgrades the old HTTP and HTTPS legacy stack to use > virtual-thread friendly locking instead of > synchronized monitors. > Most of the changes are mechanical - but there are still a numbers of subtle > non-mechanical differences that are > outlined below: > 1. src/j

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2]

2020-10-12 Thread Daniel Fuchs
On Fri, 9 Oct 2020 13:22:08 GMT, Alan Bateman wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8229867: Re-examine synchronization usages in http and https protocol >> handlers >> >> Incorporated review feedba

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2]

2020-10-09 Thread Alan Bateman
On Fri, 9 Oct 2020 11:49:30 GMT, Daniel Fuchs wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> no

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2]

2020-10-09 Thread Daniel Fuchs
On Fri, 9 Oct 2020 09:01:43 GMT, Chris Hegarty wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8229867: Re-examine synchronization usages in http and https protocol >> handlers >> >> Incorporated review feedb

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2]

2020-10-09 Thread Daniel Fuchs
On Fri, 9 Oct 2020 08:49:54 GMT, Chris Hegarty wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8229867: Re-examine synchronization usages in http and https protocol >> handlers >> >> Incorporated review feedb

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers [v2]

2020-10-09 Thread Daniel Fuchs
> Hi, > > This is a fix that upgrades the old HTTP and HTTPS legacy stack to use > virtual-thread friendly locking instead of > synchronized monitors. > Most of the changes are mechanical - but there are still a numbers of subtle > non-mechanical differences that are > outlined below: > 1. src/j

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-09 Thread Michael McMahon
On Fri, 9 Oct 2020 09:17:48 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/sun/net/www/MeteredStream.java line 123: >> >>> 121: lock(); >>> 122: try { >>> 123: if (closed) return -1; >> >> This double check of `closed` is kind of irritating. Is it really nee

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-09 Thread Daniel Fuchs
On Fri, 9 Oct 2020 08:36:03 GMT, Chris Hegarty wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> n

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-09 Thread Chris Hegarty
On Thu, 8 Oct 2020 11:22:09 GMT, Daniel Fuchs wrote: > Hi, > > This is a fix that upgrades the old HTTP and HTTPS legacy stack to use > virtual-thread friendly locking instead of > synchronized monitors. > Most of the changes are mechanical - but there are still a numbers of subtle > non-mecha

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-09 Thread Alan Bateman
On Thu, 8 Oct 2020 17:36:31 GMT, Daniel Fuchs wrote: > Mostly that was a mechanical change since openServer was synchronized before. > But I guess it seems also desirable for accessing host & port which are > protected and not final; Okay, I mis-read the old code. The syncrhonization to access

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-08 Thread Daniel Fuchs
On Thu, 8 Oct 2020 17:14:24 GMT, Alan Bateman wrote: >> Hi, >> >> This is a fix that upgrades the old HTTP and HTTPS legacy stack to use >> virtual-thread friendly locking instead of >> synchronized monitors. >> Most of the changes are mechanical - but there are still a numbers of subtle >> no

Re: RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-08 Thread Alan Bateman
On Thu, 8 Oct 2020 11:22:09 GMT, Daniel Fuchs wrote: > Hi, > > This is a fix that upgrades the old HTTP and HTTPS legacy stack to use > virtual-thread friendly locking instead of > synchronized monitors. > Most of the changes are mechanical - but there are still a numbers of subtle > non-mecha

RFR: 8229867: Re-examine synchronization usages in http and https protocol handlers

2020-10-08 Thread Daniel Fuchs
Hi, This is a fix that upgrades the old HTTP and HTTPS legacy stack to use virtual-thread friendly locking instead of synchronized monitors. Most of the changes are mechanical - but there are still a numbers of subtle non-mechanical differences that are outlined below: 1. src/java.base/share/c