Looks good to me Julia!
best regards,
-- daniel
On 17/10/2019 10:00, Julia Boes wrote:
Hi,
One test case had failed with preferIPv6Addresses=true due to an
expected return value that was set incorrectly. This is fixed in the
webrev below.
Updated webrev:
http://cr.openjdk.java.net/~jboes
Hi,
One test case had failed with preferIPv6Addresses=true due to an
expected return value that was set incorrectly. This is fixed in the
webrev below.
Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.02/
Regards,
Julia
On 16/10/2019 11:25, Daniel Fuchs wrote:
Lo
Looks good!
best regards,
-- daniel
On 16/10/2019 10:38, Julia Boes wrote:
Hi Daniel,
Thanks for reviewing the change. I added a test case as per your
suggestion.
Updated webrev:
http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.01/index.html
Regards,
Julia
On 16/10/2019 10:38, Julia Boes wrote:
Hi Daniel,
Thanks for reviewing the change. I added a test case as per your
suggestion.
Updated webrev:
http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.01/index.html
LGTM.
-Chris.
Hi Daniel,
Thanks for reviewing the change. I added a test case as per your suggestion.
Updated webrev:
http://cr.openjdk.java.net/~jboes/webrevs/8225499/webrev.01/index.html
Regards,
Julia
On 15/10/2019 14:22, Daniel Fuchs wrote:
Hi Julia,
This looks good to me.
On the test - maybe we s
Hi Julia,
This looks good to me.
On the test - maybe we should add a case where the InetAddress
parameter passed to the constructor is null, as I think
InetSocketAddress supports this.
best regards,
-- daniel
On 09/10/2019 12:24, Julia Boes wrote:
Hi,
This fix improves the handling of IPv
Julia,
On 09/10/2019 12:24, Julia Boes wrote:
Hi,
This fix improves the handling of IPv6 addresses in
InetSocketAddress::toString. The implementation now encloses the IPv6
literal in brackets, which wasn't done previously.
Example:
new InetSocketAddress("::1", 80).toString()
before: /0:0:0
Hi,
This fix improves the handling of IPv6 addresses in
InetSocketAddress::toString. The implementation now encloses the IPv6
literal in brackets, which wasn't done previously.
Example:
new InetSocketAddress("::1", 80).toString()
before: /0:0:0:0:0:0:0:1:80
after: /[0:0:0:0:0:0:0:1]:80
Addi
