Re: RFR: 8223457 java.net.ServerSocket protected constructor should throw NPE if impl null

2019-05-07 Thread Michael McMahon
Thanks. On 07/05/2019, 14:55, Daniel Fuchs wrote: Looks good to me Michael! best regards, -- daniel On 07/05/2019 14:50, Michael McMahon wrote: Could I get the following small change reviewed please? The recent change in the SocketImpl code unmasked the fact that the protected constructor of

Re: RFR: 8223457 java.net.ServerSocket protected constructor should throw NPE if impl null

2019-05-07 Thread Daniel Fuchs
Looks good to me Michael! best regards, -- daniel On 07/05/2019 14:50, Michael McMahon wrote: Could I get the following small change reviewed please? The recent change in the SocketImpl code unmasked the fact that the protected constructor of ServerSocket was not checking for a null impl param

Re: RFR: 8223457 java.net.ServerSocket protected constructor should throw NPE if impl null

2019-05-07 Thread Vyom Tiwari
Looks good to me. Vyom On Tue, May 7, 2019 at 7:20 PM Michael McMahon wrote: > Could I get the following small change reviewed please? > The recent change in the SocketImpl code unmasked the fact that > the protected constructor of ServerSocket was not checking for a null > impl parameter as req

RFR: 8223457 java.net.ServerSocket protected constructor should throw NPE if impl null

2019-05-07 Thread Michael McMahon
Could I get the following small change reviewed please? The recent change in the SocketImpl code unmasked the fact that the protected constructor of ServerSocket was not checking for a null impl parameter as required. http://cr.openjdk.java.net/~michaelm/8223457/webrev.1/ Thanks Michael