Re: RFR: 8220585: Incorrect code in MulticastSocket sample code

2019-03-13 Thread Chris Hegarty
Arthur, On 13/03/2019 16:32, Arthur Eubanks wrote: Hi, A fix for some sample code in MulticastSocket, which assumed that String.length() == String.getBytes().length, which is not true for non-ASCII Strings. http://cr.openjdk.java.net/~aeubanks/8220585/webrev.00 Looks good. Thanks. -Chris

Re: RFR: 8220585: Incorrect code in MulticastSocket sample code

2019-03-13 Thread Martin Buchholz
Looks good to me. On Wed, Mar 13, 2019 at 9:34 AM Arthur Eubanks wrote: > Hi, > > A fix for some sample code in MulticastSocket, which assumed that > String.length() == String.getBytes().length, which is not true for > non-ASCII Strings. > > http://cr.openjdk.java.net/~aeubanks/8220585/webrev.00

RFR: 8220585: Incorrect code in MulticastSocket sample code

2019-03-13 Thread Arthur Eubanks
Hi, A fix for some sample code in MulticastSocket, which assumed that String.length() == String.getBytes().length, which is not true for non-ASCII Strings. http://cr.openjdk.java.net/~aeubanks/8220585/webrev.00