Re: RFR: 8214295: Populate handlers while holding streamHandlerLock

2018-11-26 Thread Chris Hegarty
On 26/11/2018 12:12, Seán Coffey wrote: JDK-8213942 synchronization fix can be improved. Details in bug report. https://bugs.openjdk.java.net/browse/JDK-8214295 http://cr.openjdk.java.net/~coffeys/webrev.8214295/webrev/ LGTM. -Chris.

Re: RFR: 8214295: Populate handlers while holding streamHandlerLock

2018-11-26 Thread Seán Coffey
On 26/11/18 12:59, Pavel Rappo wrote: On 26 Nov 2018, at 12:12, Seán Coffey wrote: JDK-8213942 synchronization fix can be improved Looks like a soft language for what actually is a race condition. I wonder at what point should we just rewrite the thing as Alan mentioned using "fully concurre

Re: RFR: 8214295: Populate handlers while holding streamHandlerLock

2018-11-26 Thread Pavel Rappo
> On 26 Nov 2018, at 12:12, Seán Coffey wrote: > > JDK-8213942 synchronization fix can be improved Looks like a soft language for what actually is a race condition. I wonder at what point should we just rewrite the thing as Alan mentioned using "fully concurrent lookups"? -Pavel

RFR: 8214295: Populate handlers while holding streamHandlerLock

2018-11-26 Thread Seán Coffey
JDK-8213942 synchronization fix can be improved. Details in bug report. https://bugs.openjdk.java.net/browse/JDK-8214295 http://cr.openjdk.java.net/~coffeys/webrev.8214295/webrev/ -- Regards, Sean.