Re: RFR: 8209178: Proxied HttpsURLConnection doesn't send BODY when retrying POST request

2019-09-26 Thread Julia Boes
Thank you for reviewing, Vyom and Daniel. Daniel, would you push the change for me? Changeset: http://cr.openjdk.java.net/~jboes/webrevs/8209178/webrev.02/ Cheers, Julia On 25/09/2019 13:12, Daniel Fuchs wrote: Hi, On 24/09/2019 16:11, Julia Boes wrote: Hi, This fix addresses an issue in

Re: RFR: 8209178: Proxied HttpsURLConnection doesn't send BODY when retrying POST request

2019-09-25 Thread Daniel Fuchs
Hi, On 24/09/2019 16:11, Julia Boes wrote: Hi, This fix addresses an issue in HttpClient when retrying a POST request over proxied HTTPS. [...] Bug: https://bugs.openjdk.java.net/browse/JDK-8209178 Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8209178/webrev.00/index.html This look

Re: RFR: 8209178: Proxied HttpsURLConnection doesn't send BODY when retrying POST request

2019-09-24 Thread Vyom Tewari26
Hi Julia,   Fix looks good to me, i tested the fix it worked for us.   Thanks, Vyom   - Original message -From: Julia Boes Sent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] RFR: 8209178: Proxied HttpsURLConnection doesn't send BODY when retrying POST requestDate: Tue, Se

RFR: 8209178: Proxied HttpsURLConnection doesn't send BODY when retrying POST request

2019-09-24 Thread Julia Boes
Hi, This fix addresses an issue in HttpClient when retrying a POST request over proxied HTTPS. In this case, the request body is stored in a PosterOutputStream poster, which is set to null in sun/net/www/protocol/http/HttpURLConnection::sendCONNECTRequest after the first request. The fix ad