Re: RFR: 8172346 sun.net.ftp.FtpDirEntry.setCreated(Date) may expose internal represent

2018-07-24 Thread vyom tewari
Hi Chris, Thanks for review, please find my comment inline. Thanks, Vyom On Tuesday 24 July 2018 06:54 PM, Chris Hegarty wrote: On 24 Jul 2018, at 10:55, vyom tewari wrote: Hi All, Please review below a trivial fix. Webrev : http://cr.openjdk.java.net/~vtewari/8172346/webrev0.0/index.htm

Re: RFR: 8172346 sun.net.ftp.FtpDirEntry.setCreated(Date) may expose internal represent

2018-07-24 Thread Chris Hegarty
On 24 Jul 2018, at 10:55, vyom tewari wrote: > > Hi All, > > Please review below a trivial fix. > > Webrev : http://cr.openjdk.java.net/~vtewari/8172346/webrev0.0/index.html > > BugID: https://bugs.openjdk.java.net/browse/JDK-8172346 > > The above code change will avoid storing the externally

RFR: 8172346 sun.net.ftp.FtpDirEntry.setCreated(Date) may expose internal represent

2018-07-24 Thread vyom tewari
Hi All, Please review below a trivial fix. Webrev : http://cr.openjdk.java.net/~vtewari/8172346/webrev0.0/index.html BugID: https://bugs.openjdk.java.net/browse/JDK-8172346 The above code change will avoid storing the externally mutable object reference into FtpDirEntry. Thanks, Vyom