Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Chris Hegarty
On 18/04/16 11:09, Claes Redestad wrote: On 04/18/2016 12:06 PM, Chris Hegarty wrote: On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy net

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Claes Redestad
On 04/18/2016 12:06 PM, Chris Hegarty wrote: On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and a

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Chris Hegarty
On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Claes Redestad
On 04/18/2016 12:01 PM, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO c

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Claes Redestad
On 04/18/2016 11:45 AM, Chris Hegarty wrote: On 14/04/16 13:49, Claes Redestad wrote: Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ The changes look

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Alan Bateman
On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code look okay but probably should be split in

Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-18 Thread Chris Hegarty
On 14/04/16 13:49, Claes Redestad wrote: Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ The changes look fine. Maybe the bug description should be upd

RFR: 8154238: Drop code to support Windows XP in windows socket impl

2016-04-14 Thread Claes Redestad
Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ Thanks! /Claes