Thanks for the review Chris. The comments all look reasonable.
I agree SelectorAttachment is better being made static.
- Michael
On 09/03/16 10:25, Chris Hegarty wrote:
Michael,
This is a nasty bug. I agree with the notion of the attachment tracking
the interest ops. Most of my comments are r
On 09/03/16 10:24, Michael McMahon wrote:
On 08/03/16 14:10, Claes Redestad wrote:
Another oddity in the surrounding code is that
System.currentTimeMillis() is always called, but only used when
selector.select(timeval) == 0 - could this be moved into the if-block?
266 long now = System.curr
On 08/03/16 14:10, Claes Redestad wrote:
On 2016-03-08 14:42, Michael McMahon wrote:
Iterator-based removal would work, or building a new list to replace
pending with might be more efficient. The synchronization scheme
seems a bit flaky as well?
The new code is always called from the sa
Michael,
This is a nasty bug. I agree with the notion of the attachment tracking
the interest ops. Most of my comments are related to code-style, cleanup,
and closing of resources by test. Rather than trying to list them I’ve included
a webrev, generated against your patch. You can just import it,
On 2016-03-08 14:42, Michael McMahon wrote:
Iterator-based removal would work, or building a new list to replace
pending with might be more efficient. The synchronization scheme
seems a bit flaky as well?
The new code is always called from the same thread. So, I don't see an
issue?
Ri
On 08/03/16 12:15, Claes Redestad wrote:
Hi Michael,
On 2016-03-08 12:27, Michael McMahon wrote:
Could I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/8151299/webrev.1/
get on LinkedList is O(n), so the for-loop in resetInterestOps
sneakily has quadratic com
Hi Michael,
On 2016-03-08 12:27, Michael McMahon wrote:
Could I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/8151299/webrev.1/
get on LinkedList is O(n), so the for-loop in resetInterestOps sneakily
has quadratic complexity. One of many reasons ArrayList is
Could I get the following webrev reviewed please?
http://cr.openjdk.java.net/~michaelm/8151299/webrev.1/
Thanks,
Michael.
