Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Chris Hegarty
On 22/01/16 13:38, Claes Redestad wrote: On 2016-01-22 14:38, Alan Bateman wrote: On 22/01/2016 12:29, Claes Redestad wrote: : http://cr.openjdk.java.net/~redestad/8147962/webrev.02/ Looks good. -Chris.

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Claes Redestad
On 2016-01-22 14:38, Alan Bateman wrote: On 22/01/2016 12:29, Claes Redestad wrote: : http://cr.openjdk.java.net/~redestad/8147962/webrev.02/ This looks good to me. -Alan Thanks! /Claes

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Alan Bateman
On 22/01/2016 12:29, Claes Redestad wrote: : http://cr.openjdk.java.net/~redestad/8147962/webrev.02/ This looks good to me. -Alan

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Claes Redestad
On 2016-01-22 12:29, Alan Bateman wrote: On 21/01/2016 17:27, Claes Redestad wrote: Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish locales. This patch suggests using the locale-in

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-22 Thread Alan Bateman
On 21/01/2016 17:27, Claes Redestad wrote: Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish locales. This patch suggests using the locale-independent String.toLowerCase(Locale.ENGLISH

Re: RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-21 Thread Naoto Sato
Hello, I'd suggest using Locale.ROOT instead of Locale.ENGLISH for this purpose. Naoto On 1/21/16 10:57 PM, Claes Redestad wrote: Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish locales.

RFR: 8147962: URL should handle lower-casing of protocol locale-independently

2016-01-21 Thread Claes Redestad
Hi, using String.toLowerCase() in URL allows some strings to lower-case to a string that'd be invalid, e.g. "FILE".toLowerCase() -> "f\u0131le" in turkish locales. This patch suggests using the locale-independent String.toLowerCase(Locale.ENGLISH) instead, since only a-z and A-Z are legal a