Re: RFR: 8055299 HttpsURLConnection.equals() broken

2014-08-25 Thread Chris Hegarty
Michael, The source changes look fine to me, but I know you are waiting on another dependent bug to be able to update the test. -Chris. On 25/08/14 11:47, Michael McMahon wrote: Thanks for looking at it. I need to get this one reviewed first though, to re-organise one of the test support cla

Re: RFR: 8055299 HttpsURLConnection.equals() broken

2014-08-25 Thread Michael McMahon
Thanks for looking at it. I need to get this one reviewed first though, to re-organise one of the test support classes it uses https://bugs.openjdk.java.net/browse/JDK-8055747 Michael On 25/08/14 03:09, Xuelei Fan wrote: Looks fine to me. Thanks for the update. Xuelei On 8/20/2014 9:02 PM,

Re: RFR: 8055299 HttpsURLConnection.equals() broken

2014-08-24 Thread Xuelei Fan
Looks fine to me. Thanks for the update. Xuelei On 8/20/2014 9:02 PM, Michael McMahon wrote: > This is the recently reported fix to HttpsURLConnection.equals > > http://cr.openjdk.java.net/~michaelm/8055299/webrev.1/ > > The fix includes a test. Not shown in the webrev is java key store > file

RFR: 8055299 HttpsURLConnection.equals() broken

2014-08-20 Thread Michael McMahon
This is the recently reported fix to HttpsURLConnection.equals http://cr.openjdk.java.net/~michaelm/8055299/webrev.1/ The fix includes a test. Not shown in the webrev is java key store file called testkeys, which is copied from another location in the test tree and is to be installed in the same