Re: RFR : 7076487 : (sctp) SCTP API classes does not exist in JDK for Mac

2014-02-26 Thread Seán Coffey
thanks Michael. Will update copyrights before pushing. regards, Sean. On 26/02/14 16:12, Michael McMahon wrote: Looks good to me. The copyright date on the new src/macosx files could be updated though. Thanks Michael On 26/02/14 15:45, Seán Coffey wrote: Looking to backport this one to jdk7u

Re: RFR : 7076487 : (sctp) SCTP API classes does not exist in JDK for Mac

2014-02-26 Thread Chris Hegarty
Thanks Sean. Looks good to me. -Chris. On 26/02/14 15:45, Seán Coffey wrote: Looking to backport this one to jdk7u-dev. Given the different build system, the make logic is different. bug ID : https://bugs.openjdk.java.net/browse/JDK-7076487 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7

Re: RFR : 7076487 : (sctp) SCTP API classes does not exist in JDK for Mac

2014-02-26 Thread Michael McMahon
Looks good to me. The copyright date on the new src/macosx files could be updated though. Thanks Michael On 26/02/14 15:45, Seán Coffey wrote: Looking to backport this one to jdk7u-dev. Given the different build system, the make logic is different. bug ID : https://bugs.openjdk.java.net/brow

RFR : 7076487 : (sctp) SCTP API classes does not exist in JDK for Mac

2014-02-26 Thread Seán Coffey
Looking to backport this one to jdk7u-dev. Given the different build system, the make logic is different. bug ID : https://bugs.openjdk.java.net/browse/JDK-7076487 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7076487.7u/webrev/ The fix is same as the windows approach where we basically t

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Tim Bell
On 10/10/13 04:12 AM, Magnus Ihse Bursie wrote: On 2013-10-10 12:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The exist

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Magnus Ihse Bursie
On 2013-10-10 12:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Michael McMahon
On 10/10/13 12:01, Alan Bateman wrote: On 10/10/2013 11:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_s

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Alan Bateman
On 10/10/2013 11:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk

Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Chris Hegarty
Thank you for doing this Michael. The changes look good to me, but someone from the build group should cast an eye on the makefile changes. -Chris. On 10/10/2013 11:10 AM, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable c

RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac

2013-10-10 Thread Michael McMahon
Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ Thanks