Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

Am 16.01.2014 17:26, schrieb roger riggs: Please review: webrev: http://cr.openjdk.java.net/~rriggs/webrev-jnu-check-rename-8031737/ I more would like a "while (true)" loop, rather than a "do" loop. -Ulf

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

The webrev has been updated to revert the java.util.jar/pack CHECK_* macros and to clean up the macro definitions in jni_util.h. I plan to give the review some more time in case there are more comments coming. Roger On Thu, Jan 16, 2014 at 8:26 AM, roger riggs

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

Hi Kumar, The parameter names are purely local to the macro. They do not need to be unique. If the macro was longer (though it is now a lot longer than the original), it might make the code more readable. (Though I'm sure someone has a different convention). Roger On 1/16/2014 1:57 PM, Kumar

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

Roger, one more thing, shouldn't the parameters be unique ? I think Martin had me do this for all macros in the java launcher for example please see this changeset, I recently pushed. http://hg.openjdk.java.net/jdk9/dev/jdk/rev/6c50c972a101 Kumar On 1/16/2014 9:30 AM, Kumar Srinivasan wrote:

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

Hi Kumar, I will revert the changes to the native code of java.util.jar.pack. Roger On 1/16/2014 12:30 PM, Kumar Srinivasan wrote: Hi Roger, Its confusing to use a JNU_ prefixed macro on a method not involvng jni, why not rename these to modulo JNU_ ? I am cc'ing Alex as he has a related bug

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

Hi Roger, Its confusing to use a JNU_ prefixed macro on a method not involvng jni, why not rename these to modulo JNU_ ? I am cc'ing Alex as he has a related bug fix in his queue for pack's jni code. Kumar Hi Alan, The macros are generally useful even without being used on a method that in

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

Hi Alan, The macros are generally useful even without being used on a method that involves jni. An overly aggressive find caught the uses in java/util/jar/pack. But yes, it might be better to limit their scope to functions that involve jni. Roger On 1/16/2014 11:41 AM, Alan Bateman wrote

Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

On 16/01/2014 16:26, roger riggs wrote: Please review: The native macros for checking and returning when exceptions are thrown have been renamed to include the "JNU_" prefix consistent with other functions in jni_util.h. The macros have been renamed and existing uses in the jdk repository for n

RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions

Please review: The native macros for checking and returning when exceptions are thrown have been renamed to include the "JNU_" prefix consistent with other functions in jni_util.h. The macros have been renamed and existing uses in the jdk repository for networking, pack200, and have been updated