Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Chris Hegarty
> On 4 May 2017, at 17:58, Michael McMahon wrote: > > Hi Vyom, > > As discussed, I think there are still some issues including on 32 bit Linux > and since we don't > have too many of those machines left to debug with, it's probably best to > back out the original > change, and go back to the

Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Michael McMahon
Hi Vyom, As discussed, I think there are still some issues including on 32 bit Linux and since we don't have too many of those machines left to debug with, it's probably best to back out the original change, and go back to the original webrev. We can then review an updated version which takes

Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Vyom Tewari
Hi All, please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8179602/webrev0.1/index.html) which fixed the Mac OS issued as well. Michael as we we discussed off line, i incorporated the changes suggested by you, Thanks, Vyom On Thursday 04 May 2017 03:11 PM, Michael McMahon

Re: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Michael McMahon
Hi Vyom, I notice this doesn't seem to fix the Mac OS problem. We may have to file a separate issue for that. - Michael On 04/05/2017, 09:50, Vyom Tewari wrote: Hi All, Please review the below change. Webrev: http://cr.openjdk.java.net/~vtewari/8179602/webrev0.0/index.html Bugid: https://b

RE: RFR 8179602: Fix for JDK-8165437 is broken on 32-bit Linux

2017-05-04 Thread Langer, Christoph
Hi Vyom, the fix looks good and seems straightforward to resolve the reported issue. Small item: I spotted an extra space in net_util_md.h, line 75, between "jlong" and "nanoTimeStamp" which could be removed. Reviewed. Best regards Christoph > -Original Message- > From: net-dev [mailt