RE: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-30 Thread Langer, Christoph
ilto:nio-...@openjdk.java.net> Subject: Re: RFR 8158023: SocketExceptions contain too little information sometimes Hi Christoph, Looking good, its unfortunate that the handling of mixed platform and utf string require jni up calls to invoke java methods. jni_util.c: line 216: You shou

Re: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-29 Thread Roger Riggs
Yep, Thanks, Roger Thanks Christoph -Original Message- From: nio-dev [mailto:nio-dev-boun...@openjdk.java.net] On Behalf Of Roger Riggs Sent: Mittwoch, 29. Juni 2016 20:20 To: nio-...@openjdk.java.net Subject: Re: RFR 8158023: SocketExceptions contain too little information sometime

RE: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-29 Thread Langer, Christoph
Riggs > Sent: Mittwoch, 29. Juni 2016 20:20 > To: nio-...@openjdk.java.net > Subject: Re: RFR 8158023: SocketExceptions contain too little information > sometimes > > Hi Christoph, > > Looking good, its unfortunate that the handling of mixed platform and > utf string requir

RE: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-28 Thread Langer, Christoph
-libs-...@openjdk.java.net; net-dev@openjdk.java.net Subject: Re: RFR 8158023: SocketExceptions contain too little information sometimes Christoph, I didn't understand your explanation on your message preference. Typically root cause information is printed last, not first. Another reason no

Re: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-27 Thread Mark Sheppard
zumura [mailto:k...@jp.fujitsu.com] Sent: Mittwoch, 8. Juni 2016 02:51 To: Langer, Christoph Cc: net-dev@openjdk.java.net; nio-...@openjdk.java.net; core-libs- d...@openjdk.java.net Subject: Re: RFR 8158023: SocketExceptions contain too little information sometimes Christoph, Y

RE: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-27 Thread Langer, Christoph
gt; Christoph > > > >> -Original Message- > >> From: Kenji Kazumura [mailto:k...@jp.fujitsu.com] > >> Sent: Mittwoch, 8. Juni 2016 02:51 > >> To: Langer, Christoph > >> Cc: net-dev@openjdk.java.net; nio-...@openjdk.java.net; core-libs- > >> d...@openj

Re: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-27 Thread Mark Sheppard
penjdk.java.net Subject: Re: RFR 8158023: SocketExceptions contain too little information sometimes Christoph, You should not remove conversion codes (platform string to Java String) at JNU_ThrowByNameWithLastError, and you have to add conversion codes at JNU_ThrowByNameWithMessageAndLastError. I

RE: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-27 Thread Langer, Christoph
> -Original Message- > From: Kenji Kazumura [mailto:k...@jp.fujitsu.com] > Sent: Mittwoch, 8. Juni 2016 02:51 > To: Langer, Christoph > Cc: net-dev@openjdk.java.net; nio-...@openjdk.java.net; core-libs- > d...@openjdk.java.net > Subject: Re: RFR 8158023: SocketExceptions c

Re: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-08 Thread Kenji Kazumura
Christoph, You should not remove conversion codes (platform string to Java String) at JNU_ThrowByNameWithLastError, and you have to add conversion codes at JNU_ThrowByNameWithMessageAndLastError. It seems that you assume strerror returns only ascii characters, but actually not. It depends on the

RE: RFR 8158023: SocketExceptions contain too little information sometimes

2016-06-08 Thread Langer, Christoph
To: Langer, Christoph > Cc: net-dev@openjdk.java.net; nio-...@openjdk.java.net; core-libs- > d...@openjdk.java.net > Subject: Re: RFR 8158023: SocketExceptions contain too little information > sometimes > > Christoph, > > You should not remove conversi