RE: 8199329: Remove code that attempts to read bytes after connection reset reported

2018-03-14 Thread Langer, Christoph
Hi Alan, looks good to me, +1. Best regards Christoph > -Original Message- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of > Alan Bateman > Sent: Mittwoch, 14. März 2018 15:31 > To: OpenJDK Network Dev list > Subject: 8199329: Remove code that attempts to read byt

Re: 8199329: Remove code that attempts to read bytes after connection reset reported

2018-03-14 Thread Chris Hegarty
On 14/03/18 14:30, Alan Bateman wrote: Classic networking has some curious code to deal with connection resets. I needed to dig into ancient history to find the issues and original motivations. When a connection reset is reported (usually ECONNRESET) then further attempts to read from the

Re: 8199329: Remove code that attempts to read bytes after connection reset reported

2018-03-14 Thread Claes Redestad
Looks good to me. /Claes On 2018-03-14 15:30, Alan Bateman wrote: Classic networking has some curious code to deal with connection resets. I needed to dig into ancient history to find the issues and original motivations. When a connection reset is reported (usually ECONNRESET) then further

Re: 8199329: Remove code that attempts to read bytes after connection reset reported

2018-03-14 Thread David Lloyd
+1 from me (non-reviewer). Semantically, it is impossible to distinguish the difference between the OS dropping bytes when it receives an RST compared to Java doing the same thing, so there is no observable behavior change here AFAICT. On Wed, Mar 14, 2018 at 9:30 AM, Alan Bateman wrote: > > Cla