Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Norman Maurer
> On 1. Jun 2018, at 17:40, Chris Hegarty wrote: > > Norman, > > On 01/06/18 16:33, Norman Maurer wrote: >> ... >> Sure thing (its exactly the same code as in the pr): > > Thank you. I just want to run some tests and verify any > potential changes to satisfy myself, so I will be in a > bette

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Chris Hegarty
Norman, On 01/06/18 16:33, Norman Maurer wrote: ... Sure thing (its exactly the same code as in the pr): Thank you. I just want to run some tests and verify any potential changes to satisfy myself, so I will be in a better position to review the code once Alan posts a review request. -Chris

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Norman Maurer
Hi Chris, > On 1. Jun 2018, at 17:28, Chris Hegarty wrote: > > Hi Norman, > > On 30/05/18 09:16, Norman Maurer wrote: >> ... >> I added a reproducer which not uses any netty classes to the PR that for now >> ignores test-failures caused by this when running on Java11+: >> https://github.com/

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Chris Hegarty
Hi Norman, On 30/05/18 09:16, Norman Maurer wrote: ... I added a reproducer which not uses any netty classes to the PR that for now ignores test-failures caused by this when running on Java11+: https://github.com/netty/netty/pull/7984#issuecomment-393071386 Would it be possible for you to p

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Norman Maurer
> On 1. Jun 2018, at 14:50, Alan Bateman wrote: > > > > On 01/06/2018 13:19, Florian Weimer wrote: >> >> But there is a race, even on Linux. If the network is fast enough and you >> get an RST segment from the other end, kernel the receive buffer is >> discarded. > Right although it can

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Alan Bateman
On 01/06/2018 13:19, Florian Weimer wrote: But there is a race, even on Linux.  If the network is fast enough and you get an RST segment from the other end, kernel the receive buffer is discarded. Right although it can be a bit more predictable with loopback connections. So whatever you

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Norman Maurer
> On 1. Jun 2018, at 14:13, Alan Bateman wrote: > > On 01/06/2018 10:21, Florian Weimer wrote: >> On 05/29/2018 04:26 PM, Norman Maurer wrote: >>> Yes thats what I am saying… I think if a write fails due a connection-reset >>> a read should still be possible until we are told by the OS that w

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Florian Weimer
On 06/01/2018 02:13 PM, Alan Bateman wrote: I can't say for sure whether the kernels actually drop the socket buffer or not. For the scenario, the connection reset is reported when writing and on both Linux and macOS you can read the previously received bytes in the socket buffer. But there i

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Alan Bateman
On 01/06/2018 10:21, Florian Weimer wrote: On 05/29/2018 04:26 PM, Norman Maurer wrote: Yes thats what I am saying… I think if a write fails due a connection-reset a read should still be possible until we are told by the OS that we also hit an error here. Are there implementations where the k

Re: Problem with half-closure related to connection-reset in Java 11

2018-06-01 Thread Florian Weimer
On 05/29/2018 04:26 PM, Norman Maurer wrote: Yes thats what I am saying… I think if a write fails due a connection-reset a read should still be possible until we are told by the OS that we also hit an error here. Are there implementations where the kernel does *not* zap the read buffer when

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-31 Thread Norman Maurer
> Am 31.05.2018 um 20:41 schrieb Alan Bateman : > > > >> On 31/05/2018 18:08, Norman Maurer wrote: >> : >>> [1] https://bugs.openjdk.java.net/browse/JDK-8203937 >> Also let me know if you need anything else or want me to test something >> > I saw your other mail where you posted a link to gi

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-31 Thread Alan Bateman
On 31/05/2018 18:08, Norman Maurer wrote: : [1] https://bugs.openjdk.java.net/browse/JDK-8203937 Also let me know if you need anything else or want me to test something I saw your other mail where you posted a link to giithub. I should have replied to ask you to attach the test so that it

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-31 Thread Norman Maurer
> Am 29.05.2018 um 22:49 schrieb Alan Bateman : > >> On 29/05/2018 17:28, Norman Maurer wrote: >> : >> Oh sorry I thought thats the right system to use. I just followed the wiki >> page (I think). > bugs.sun.com or bugreport.java.com is the right place. That routes the bugs > to the JIRA, jus

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-30 Thread Norman Maurer
> On 30. May 2018, at 09:14, Norman Maurer wrote: > > > >> On 29. May 2018, at 22:49, Alan Bateman > > wrote: >> >> On 29/05/2018 17:28, Norman Maurer wrote: >>> : >>> Oh sorry I thought thats the right system to use. I just followed the wiki >>> page (I thin

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-30 Thread Norman Maurer
> On 29. May 2018, at 22:49, Alan Bateman wrote: > > On 29/05/2018 17:28, Norman Maurer wrote: >> : >> Oh sorry I thought thats the right system to use. I just followed the wiki >> page (I think). > bugs.sun.com or bugreport.java.com is the right place. That routes the bugs > to the JIRA, jus

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-29 Thread Alan Bateman
On 29/05/2018 17:28, Norman Maurer wrote: : Oh sorry I thought thats the right system to use. I just followed the wiki page (I think). bugs.sun.com or bugreport.java.com is the right place. That routes the bugs to the JIRA, just not automatically to the right project as often issues need to be

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-29 Thread Norman Maurer
> On 29. May 2018, at 18:26, Alan Bateman wrote: > > On 29/05/2018 15:26, Norman Maurer wrote: >> : >> >> >> Yes thats what I am saying… I think if a write fails due a connection-reset >> a read should still be possible until we are told by the OS that we also hit >> an error here. Honestl

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-29 Thread Alan Bateman
On 29/05/2018 15:26, Norman Maurer wrote: : Yes thats what I am saying… I think if a write fails due a connection-reset a read should still be possible until we are told by the OS that we also hit an error here. Honestly I think this scenario can happen quite often in reality where some soft

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-29 Thread Norman Maurer
> On 29. May 2018, at 16:19, Alan Bateman wrote: > > On 29/05/2018 14:52, Norman Maurer wrote: >> Hi all, >> >> After trying to run our testsuite in Netty [1] with Java11+ea15 I noticed we >> have one failing test that seems to be related to: >> >> https://bugs.openjdk.java.net/browse/JDK-8

Re: Problem with half-closure related to connection-reset in Java 11

2018-05-29 Thread Alan Bateman
On 29/05/2018 14:52, Norman Maurer wrote: Hi all, After trying to run our testsuite in Netty [1] with Java11+ea15 I noticed we have one failing test that seems to be related to: https://bugs.openjdk.java.net/browse/JDK-8199329 http://hg.openjdk.java.net/jdk/jdk/rev/92cca24c8807 I think the c

Problem with half-closure related to connection-reset in Java 11

2018-05-29 Thread Norman Maurer
Hi all, After trying to run our testsuite in Netty [1] with Java11+ea15 I noticed we have one failing test that seems to be related to: https://bugs.openjdk.java.net/browse/JDK-8199329 http://hg.openjdk.java.net/jdk/jdk/rev/92cca24c8807