Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

2017-06-06 Thread Weijun Wang
On 06/06/2017 01:43 PM, Felix Yang wrote: Missed "Add back read access" before trying to delete it? Based on my test results (local and JPRT), it deleted w/o any exceptions. This was originally added by Max in https://bugs.openjdk.java.net/browse/JDK-7078355. TO Max, could you comment if suc

Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

2017-06-05 Thread Felix Yang
Amy, thanks for the comments. On 2017/6/6 10:37, Amy Lu wrote: sun/net/www/protocol/file/DirPermissionDenied.java + + @BeforeTest + public void setup() throws Throwable { + // mkdir and chmod "333" + Files.createDirectories(TEST_DIR); + ProcessTools.executeCommand("chmod", "333", TEST_DIR.

Re: Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

2017-06-05 Thread Amy Lu
sun/net/www/protocol/file/DirPermissionDenied.java + + @BeforeTest + public void setup() throws Throwable { + // mkdir and chmod "333" + Files.createDirectories(TEST_DIR); + ProcessTools.executeCommand("chmod", "333", TEST_DIR.toString()) Maybe just do this with java api instead run chmod comman

Ping~ Re: RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

2017-06-05 Thread Felix Yang
Thanks:-) -Felix On 2017/6/1 16:32, Felix Yang wrote: Hi there, please review the patch convert several sun/net shell tests to plain java tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8181080 Webrev: http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/ Thanks, Felix