Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Kelly O'Hair
Andrew, Let me know if you have any suggestions on changes to the developers guide, especially the repositories.html page. I don't want to do massive edits to it, but I certainly can make misc. smaller changes, corrections and additions. -kto

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Brad Wetmore
> Oh, I agree. I just thought I'd use the opportunity to point out to > everyone that a) there is some documentation of this and, more > importantly, b) it needs updating. Kelly's been following this thread, but I haven't seen the note about the webrev here. His latest webrev (posted to guide-

Re: Updated patch for JTReg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Christopher Hegarty - Sun Microsystems Ireland
This change looks fine. -Chris. On 24/09/2009 10:01, Pavel Tisnovsky wrote: Hi, updated patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinfIf_isUp/ This patch ensures, that this test uses only network de

Re: Updated patch for JTReg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Alan Bateman
Pavel Tisnovsky wrote: Hi, updated patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinfIf_isUp/ This patch ensures, that this test uses only network devices supporting multicast and also that the device is

Updated patch for JTReg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-24 Thread Pavel Tisnovsky
Hi, updated patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinfIf_isUp/ This patch ensures, that this test uses only network devices supporting multicast and also that the device is in "up" state. Tested

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Kelly O'Hair
Andrew John Hughes wrote: 2009/9/23 Andrew Haley : Andrew John Hughes wrote: 2009/9/23 Andrew Haley : Christopher Hegarty -Sun Microsystems Ireland wrote: [cc'ing net-dev] I see you have push access, so if you make the appropriate changes (mentioned above) I can review the webrev and you c

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Christopher Hegarty -Sun Microsystems Ireland
Pavel, This change should be integrated into the tl/jdk [1] repository. You can plan to integrate after code review, or if you prefer just let me know and I can take care of it for you. -Chris. [1] http://hg.openjdk.java.net/jdk7/tl/jdk/ Pavel Tisnovsky wrote: Christopher, thank you for y

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew John Hughes
2009/9/23 Andrew Haley : > Andrew John Hughes wrote: >> 2009/9/23 Andrew Haley : >>> Christopher Hegarty -Sun Microsystems Ireland wrote: [cc'ing net-dev] I see you have push access, so if you make the appropriate changes (mentioned above) I can review the webrev and you can use

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew Haley
Andrew John Hughes wrote: > 2009/9/23 Andrew Haley : >> Christopher Hegarty -Sun Microsystems Ireland wrote: >>> [cc'ing net-dev] >>> >>> I see you have push access, so if you make the appropriate changes >>> (mentioned above) I can review the webrev and you can use the above bug >>> number and des

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew Haley
Christopher Hegarty -Sun Microsystems Ireland wrote: > [cc'ing net-dev] > > Alan Bateman wrote: >> Pavel Tisnovsky wrote: >>> Hi, >>> >>> two-lines patch for regression test >>> java/net/MulticastSocket/SetOutgoingIf.java is exposed at >>> http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/ >

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Pavel Tisnovsky
Christopher, thank you for your answer. I'll update the test and make the webrev. FYI: in fact, the test java/net/MulticastSocket/Test.java fails too on my machine, but I just not (yet) investigated the issue. It fails with exception java.net.SocketException: Cannot assign requested address.

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Andrew John Hughes
2009/9/23 Andrew Haley : > Christopher Hegarty -Sun Microsystems Ireland wrote: >> [cc'ing net-dev] >> >> Alan Bateman wrote: >>> Pavel Tisnovsky wrote: Hi, two-lines patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.

Re: Patch for JTreg test java/net/MulticastSocket/SetOutgoingIf.java

2009-09-23 Thread Christopher Hegarty -Sun Microsystems Ireland
[cc'ing net-dev] Alan Bateman wrote: Pavel Tisnovsky wrote: Hi, two-lines patch for regression test java/net/MulticastSocket/SetOutgoingIf.java is exposed at http://cr.openjdk.java.net/~ptisnovs/JTReg_SetOutgoinIf/ The test machine (where this test fails) has six network interfaces, but o