Re: HttpClient Send Method Guaranteed Completion

2021-10-07 Thread Elliot Barlas
. From: Michael McMahon Sent: Thursday, October 7, 2021 7:40 AM To: Daniel Fuchs ; Elliot Barlas ; net-dev@openjdk.java.net Subject: Re: HttpClient Send Method Guaranteed Completion I think we should at least clarify the behavior of HttpRequest.Builder.timeout() ie. that it is specifically related

Re: HttpClient Send Method Guaranteed Completion

2021-10-07 Thread Michael McMahon
I think we should at least clarify the behavior of HttpRequest.Builder.timeout() ie. that it is specifically related to the response headers, and maybe consider adding a timeout variant that sets the timeout for the entire response, including the body. - Michael. On 06/10/2021 10:42, Daniel F

Re: HttpClient Send Method Guaranteed Completion

2021-10-06 Thread Elliot Barlas
Thank you for pointing that out! That addresses my immediate concern. This ought to work just fine. From: Daniel Fuchs Sent: Wednesday, October 6, 2021 12:08 PM To: Elliot Barlas ; net-dev@openjdk.java.net Subject: Re: HttpClient Send Method Guaranteed

Re: HttpClient Send Method Guaranteed Completion

2021-10-06 Thread Daniel Fuchs
On 06/10/2021 10:42, Daniel Fuchs wrote:   } catch (TimeoutException x) {   // timeout: cancel request to free up   //   any related resources   cf.cancel(); Correction: that should be `cf.cancel(true)`

Re: Re: HttpClient Send Method Guaranteed Completion

2021-10-06 Thread Daniel Fuchs
Hi Eliot, On 06/10/2021 18:22, Elliot Barlas wrote: Thanks for the reply, Daniel. This was an HTTP 1.1 connection. The code snippet for building the URL and configuring the HttpClient was included in my previous email for reference. I can't make any claims about what was happening with pack

Re: HttpClient Send Method Guaranteed Completion

2021-10-06 Thread Elliot Barlas
Subject: Re: HttpClient Send Method Guaranteed Completion Hi Eliot, Unless the server keeps the connection open, and fails to send all the body bytes it has promised to send, the send operation should eventually terminate. The behavior you describe looks indeed like a bug. Could you please lo

Re: HttpClient Send Method Guaranteed Completion

2021-10-06 Thread Daniel Fuchs
Hi Eliot, Unless the server keeps the connection open, and fails to send all the body bytes it has promised to send, the send operation should eventually terminate. The behavior you describe looks indeed like a bug. Could you please log a ticket with: https://bugreport.java.com/bugreport/ That

HttpClient Send Method Guaranteed Completion

2021-10-05 Thread Elliot Barlas
Hello net-dev! I'm emailing about a surprising observation in the HttpClient send method related to guaranteed completion. Despite explicit timeout configurations, a call to send can block indefinitely. The stacktrace below was obtained from a thread dump on a running OpenJDK 16.0.2 JVM. The t