Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Dmitry Samersoff
Michael, NTLMAuthentication.java: 1. Copyright year should be either fixed or not changed 2. I think it's better to remove bug id from comments and replace comment like // MMM 7200720 ?? to something better. NTLMAuthSequence.c 1. Copyright ... Otherwise looks good for me. -Dmitry

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Chris Hegarty
I'm ok with this change. -Chris. On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/720072

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Alan Bateman
On 28/11/2012 13:47, Michael McMahon wrote: just checked the new build on Linux and it's fine. There are a couple of other fixes that will follow this one related to this problem. But, I'd like to go ahead and push this one first if possible - Michael Thanks for checking. I don't have cycles

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-28 Thread Michael McMahon
On 23/11/12 16:16, Alan Bateman wrote: On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-23 Thread Michael McMahon
On 23/11/12 16:16, Alan Bateman wrote: On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7

Re: Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-23 Thread Alan Bateman
On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ I haven't reviewed the

Code review: 7200720: crash in net.dll during NTLM authentication

2012-11-23 Thread Michael McMahon
Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ Thanks Michael