Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

2013-07-26 Thread Andreas Rieber
Hi Kurchi, i looked into the change. Today i did run it a few time and it allays worked. The logic looks straight forward to me. I would only improve indenting and the try - autoclose for the Server. The startServer() can be implemented in the constructor. The server.close() in the exept() m

Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

2013-07-25 Thread Kurchi Subhra Hazra
Hi, Did anyone have a chance to look at this? Thanks, Kurchi On Thu, Jul 18, 2013 at 4:26 PM, Kurchi Hazra < kurchi.subhra.ha...@oracle.com> wrote: > Hi Michael, > >I added some comments as to what is the purpose of the latches and > barriers. Those comments alongwith the > comments descri

Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

2013-07-18 Thread Kurchi Hazra
Hi Michael, I added some comments as to what is the purpose of the latches and barriers. Those comments alongwith the comments describing the purpose of the handlers should make the synchronization logic more clear. Let me know what you think: http://cr.openjdk.java.net/~khazra/8017779/webr

Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

2013-07-17 Thread Kurchi Hazra
On 7/17/2013 12:27 AM, Michael McMahon wrote: On 16/07/13 20:11, Kurchi Hazra wrote: Hi, We have observed that test/java/net/Authenticator/B4769350.java fails intermittently. Although not reproducible always, the bug could be in the test/sun/net/www/httptest library that this test uses.

Re: Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

2013-07-17 Thread Michael McMahon
On 16/07/13 20:11, Kurchi Hazra wrote: Hi, We have observed that test/java/net/Authenticator/B4769350.java fails intermittently. Although not reproducible always, the bug could be in the test/sun/net/www/httptest library that this test uses. I have rewritten the test to use com.sun.net.htt

Code Review Request: 8017779: java/net/Authenticator/B4769350.java fails

2013-07-16 Thread Kurchi Hazra
Hi, We have observed that test/java/net/Authenticator/B4769350.java fails intermittently. Although not reproducible always, the bug could be in the test/sun/net/www/httptest library that this test uses. I have rewritten the test to use com.sun.net.httpserver instead since we anyway want to