Re: Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself

2011-11-14 Thread Chris Hegarty
On 11/11/2011 18:57, Kurchi Hazra wrote: Hi, As specified in the CR description, this is a bug in src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() should be called instead of socketSetOption(). This bug did not create a problem yet since setOption() is usually called for set

Re: Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself

2011-11-11 Thread Alan Bateman
On 11/11/2011 18:57, Kurchi Hazra wrote: Hi, As specified in the CR description, this is a bug in src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() should be called instead of socketSetOption(). This bug did not create a problem yet since setOption() is usually called f

Code Review Request: 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself

2011-11-11 Thread Kurchi Hazra
Hi, As specified in the CR description, this is a bug in src/windows/java/net/PlainSocketImpl.java and impl.socketSetOption() should be called instead of socketSetOption(). This bug did not create a problem yet since setOption() is usually called for setting socket options. Submitting hg d