Socket.java has some commented out code. I think it should just be
removed, right?
I'm guessing this is the only change to the previous webrev? If so, it
should be good to go. I don't think you need to re-generate a webrev for
the above trivial change.
-Chris
On 09/16/11 06:17 PM, Kurchi Ha
Updated webrev:
http://cr.openjdk.java.net/~sherman/kurchi/7090158/webrev/
Thanks,
Kurchi
On 9/14/2011 12:42 PM, chris hegarty wrote:
Kurchi,
The problem here is that due to a bug in the compiler, CR 7090499, we
are not seeing raw type warnings for anonymous inner classes.
When Maurizio fi
234 l = new ArrayList<>();
Do we have a consensus on whether diamond can be used here? i.e.
assignment not on declaration.
Waiting for someone's input on this. In retrospect, I feel this is not
exactly how the diamond operator is meant to be used when I refer to
http://download.oracle.com/java
Kurchi,
The problem here is that due to a bug in the compiler, CR 7090499, we
are not seeing raw type warnings for anonymous inner classes.
When Maurizio fixes this bug it is very likely that other areas of the
jdk where Sasha enabled -Werror will break the build.
If you like you can comple
3. java/net/DatagramSocket.java and java/net/MulticastSocket.java have
some real code changes around bind(). Maybe they should go to another fix?
I think there is some merging problem in my workspace. I will probably
start with an updated copy of these files and insert my changes in them.
S
On 14/09/2011 16:46, Kurchi Hazra wrote:
+ Class[] cl = new Class[2];
+ cl[0] = SocketAddress.class;
+ cl[1] = Integer.TYPE;
+ Class clazz = impl.getClass();
I have to say, I think that would read better as:
Class[] cl = { SocketAddress.class, int.class };
Class clazz = impl
I remember having made this change as follows:
-bash-3.00$ hg diff src/share/classes/java/net/Socket.java
diff --git a/src/share/classes/java/net/Socket.java
b/src/share/classes/java/net/Socket.java
--- a/src/share/classes/java/net/Socket.java
+++ b/src/share/classes/java/net/Socket.java
@@ -459
Maurizio and I noticed another issue in java.net.Socket
> Class[] cl = new Class[2];
should generate a warning, but does not. Maurizio filed CR 7090499
against this. It is a compiler bug.
It should be: Class[] cl = new Class[2];
It is best that we fix this before pushing as it will break the
On 9/13/11 10:55 PM, Weijun Wang wrote:
> I apply the patch to my local repository and do a clean rebuild of
> jdk-only. It shows 1 error and 92 warnings in javax and stopped. Most in
> src/share/classes/javax/xml/crypto/dsig and I remember Sean said it's
> not easy to remove all warnings there
Thanks for reviewing this Max, I also went through the changes.
MessageHeader.filterAndAddHeaders() and
HttpURLConnection.getRequestproperties() also confused me. Essentially
this never work quite right. I had Maurizio ( javac guy ) look at the
old code with me and we figured out that the gene
Weijun Wang wrote:
:
3. java/net/DatagramSocket.java and java/net/MulticastSocket.java have
some real code changes around bind(). Maybe they should go to another
fix?
I suspect there may be a merge issue here as it looks like it is undoing
recent changes that Michael pushed.
-Alan.
On 09/14/2011 12:14 PM, Kurchi Hazra wrote:
Updated webrev : http://cr.openjdk.java.net/~weijun/7090158/webrev.00/.
This should build correctly.
Yes, it does!
Some comments:
1. make/java/Makefile has no real change
2. make/javax/others/Makefile has only a new commented line
3. java/net/Da
Updated webrev : http://cr.openjdk.java.net/~weijun/7090158/webrev.00/.
This should build correctly.
Thanks,
Kurchi
On 9/13/2011 7:55 PM, Weijun Wang wrote:
I apply the patch to my local repository and do a clean rebuild of
jdk-only. It shows 1 error and 92 warnings in javax and stopped. Most
I apply the patch to my local repository and do a clean rebuild of
jdk-only. It shows 1 error and 92 warnings in javax and stopped. Most in
src/share/classes/javax/xml/crypto/dsig and I remember Sean said it's
not easy to remove all warnings there because the codes are shared
between JDK and so
Kurchi Hazra wrote:
Something went wrong in the pasting. Can you check if this works fine:
http://cr.openjdk.java.net/~chegar/7090158/webrev/
Yes, this webrev has what I expected to see.
-Alan
Something went wrong in the pasting. Can you check if this works fine:
http://cr.openjdk.java.net/~chegar/7090158/webrev/
On 9/13/2011 12:07 PM, Alan Bateman wrote:
Kurchi Hazra wrote:
Hi,
This is an attempt to remove all build warnings that are related to
networking in jdk. This work conta
Kurchi Hazra wrote:
Hi,
This is an attempt to remove all build warnings that are related to
networking in jdk. This work contains
(a) Small changes in java files to remove already existing warnings
(b) Small changes in Makefiles to prevent re-introduction of such
warnings.
Webrev: http:/
Hi,
This is an attempt to remove all build warnings that are related to
networking in jdk. This work contains
(a) Small changes in java files to remove already existing warnings
(b) Small changes in Makefiles to prevent re-introduction of such warnings.
Webrev: http://cr.openjdk.java.net/~c
18 matches
Mail list logo
