Re: Code Review 7022269: clean up fscanf usage in soalris networking native code

2011-02-25 Thread Michael McMahon
Chris Hegarty wrote: On 02/25/11 05:22 PM, Michael McMahon wrote: Chris Hegarty wrote: On 02/25/11 02:39 PM, Michael McMahon wrote: Alan Bateman wrote: Chris Hegarty wrote: Michael, Alan, Some small cleanups to the use of scanf with specified string width. The buffers should be sized large

Re: Code Review 7022269: clean up fscanf usage in soalris networking native code

2011-02-25 Thread Michael McMahon
Chris Hegarty wrote: On 02/25/11 02:39 PM, Michael McMahon wrote: Alan Bateman wrote: Chris Hegarty wrote: Michael, Alan, Some small cleanups to the use of scanf with specified string width. The buffers should be sized large enough to handle the specified width and the null terminator. http:

Re: Code Review 7022269: clean up fscanf usage in soalris networking native code

2011-02-25 Thread Chris Hegarty
On 02/25/11 02:39 PM, Michael McMahon wrote: Alan Bateman wrote: Chris Hegarty wrote: Michael, Alan, Some small cleanups to the use of scanf with specified string width. The buffers should be sized large enough to handle the specified width and the null terminator. http://cr.openjdk.java.net/

Re: Code Review 7022269: clean up fscanf usage in soalris networking native code

2011-02-25 Thread Michael McMahon
Alan Bateman wrote: Chris Hegarty wrote: Michael, Alan, Some small cleanups to the use of scanf with specified string width. The buffers should be sized large enough to handle the specified width and the null terminator. http://cr.openjdk.java.net/~chegar/7022269/webrev.00/webrev/ -Chris.

Re: Code Review 7022269: clean up fscanf usage in soalris networking native code

2011-02-25 Thread Alan Bateman
Chris Hegarty wrote: Michael, Alan, Some small cleanups to the use of scanf with specified string width. The buffers should be sized large enough to handle the specified width and the null terminator. http://cr.openjdk.java.net/~chegar/7022269/webrev.00/webrev/ -Chris. Looks okay although s

Code Review 7022269: clean up fscanf usage in soalris networking native code

2011-02-25 Thread Chris Hegarty
Michael, Alan, Some small cleanups to the use of scanf with specified string width. The buffers should be sized large enough to handle the specified width and the null terminator. http://cr.openjdk.java.net/~chegar/7022269/webrev.00/webrev/ -Chris.