Re: Code Review 6954525: Testcase failure java/net/Authenticator/B4769350.java

2010-06-28 Thread Weijun Wang
On 06/28/2010 08:04 PM, Chris Hegarty wrote: On 06/28/10 08:30 AM, Weijun Wang wrote: Hi Chris I remember the reason that disconnectWeb() (or disconnectInternal() before 6586707) is called is that somewhere in the HTTP spec it's said a disconnect is needed when a 401 error is received. Howeve

Re: Code Review 6954525: Testcase failure java/net/Authenticator/B4769350.java

2010-06-28 Thread Chris Hegarty
On 06/28/10 08:30 AM, Weijun Wang wrote: Hi Chris I remember the reason that disconnectWeb() (or disconnectInternal() before 6586707) is called is that somewhere in the HTTP spec it's said a disconnect is needed when a 401 error is received. However, when I try to search for this in RFC 2616, I

Re: Code Review 6954525: Testcase failure java/net/Authenticator/B4769350.java

2010-06-28 Thread Weijun Wang
Hi Chris I remember the reason that disconnectWeb() (or disconnectInternal() before 6586707) is called is that somewhere in the HTTP spec it's said a disconnect is needed when a 401 error is received. However, when I try to search for this in RFC 2616, I cannot find anything. Do you remember

Re: Code Review 6954525: Testcase failure java/net/Authenticator/B4769350.java

2010-06-27 Thread Weijun Wang
Hi Chris We just had a 1.5-day team building and a weekend, and I just noticed this mail. The disconnectWeb() method was added in "6586707: NTLM authentication with proxy fails" to support 2-layer NTLM authentications. There was no regression test to that fix. I'll need a little time to setu

Code Review 6954525: Testcase failure java/net/Authenticator/B4769350.java

2010-06-23 Thread Chris Hegarty
Hi Michael, Max, This is a code review request for CR 6954525: Testcase failure java/net/Authenticator/B4769350.java. Essentially, there is a race among requesting threads in the test. The threads are making HTTP requests requiring authentication. This is fine, and what the test is trying to