Re: Code Review 6937703: java/net regression test issues with samevm

2010-03-24 Thread Christopher Hegarty - Sun Microsystems Ireland
On 24/03/2010 11:46, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: : Thanks Alan, I've made the changes you suggested and updated the webrev. Good okay to me. In passing I see HttpTest.run also silently consumes any exceptions so you might want to do this while you

Re: Code Review 6937703: java/net regression test issues with samevm

2010-03-24 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: : Thanks Alan, I've made the changes you suggested and updated the webrev. Good okay to me. In passing I see HttpTest.run also silently consumes any exceptions so you might want to do this while you are there (not wishing to extend the scop

Re: Code Review 6937703: java/net regression test issues with samevm

2010-03-24 Thread Christopher Hegarty - Sun Microsystems Ireland
On 24/03/2010 11:06, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Alan, Some more test updates for samevm mode. Webrev: http://cr.openjdk.java.net/~chegar/6937703/webrev.00/webrev/ -Chris. In HttpTest.java I see exceptions are silently consumed - whil

Re: Code Review 6937703: java/net regression test issues with samevm

2010-03-24 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, Alan, Some more test updates for samevm mode. Webrev: http://cr.openjdk.java.net/~chegar/6937703/webrev.00/webrev/ -Chris. In HttpTest.java I see exceptions are silently consumed - while you are there it would be good to at l

Code Review 6937703: java/net regression test issues with samevm

2010-03-24 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, Alan, Some more test updates for samevm mode. Webrev: http://cr.openjdk.java.net/~chegar/6937703/webrev.00/webrev/ -Chris.