On 02/07/2020 19:35, Alan Bateman wrote:
Looks okay although I assume you mean "are equal" rather than "are
equals" ("equals" would be okay if it were clear it means the equals
method).
Darn. I'll fix the typo! Thanks Alan.
On 02/07/2020 18:47, Daniel Fuchs wrote:
I made the requested changes:
http://cr.openjdk.java.net/~dfuchs/webrev_8248703/webrev.02
If I don't hear any objections I will proceed and push
to 15 by tomorrow.
Looks okay although I assume you mean "are equal" rather than "are
equals" ("equals"
Thanks Alan!
On 02/07/2020 18:26, Alan Bateman wrote:
"if both name and bound IP addresses are the same for both" is okay but
might be more consistent with some of the other methods if you tweak it
something like "if the names are equal and the set of {@code
InetAddress}es bound to the interfa
On 02/07/2020 15:32, Daniel Fuchs wrote:
Good point. I was momentarily confused by the @see
InetAddress.getAddress.
Webrev updated:
http://cr.openjdk.java.net/~dfuchs/webrev_8248703/webrev.01/
Is this still appropriate to push to 15 or should I rather aim at 16?
"if both name and bound IP ad
> On 2 Jul 2020, at 15:32, Daniel Fuchs wrote:
>
> ...
>
> Webrev updated:
> http://cr.openjdk.java.net/~dfuchs/webrev_8248703/webrev.01/
>
> Is this still appropriate to push to 15 or should I rather aim at 16?
LGTM. I don’t have a strong opinion which release this goes into.
-Chris.
On 02/07/2020 14:29, Alan Bateman wrote:
I assume the "Note" can be an @apiNote. I think that part reads okay
(and doesn't a CSR).
OK - I'll withdraw it and hide it away then :-)
NetworkInterface is currently spec'ed to use phrases like "InetAddresses
bound to the network interface" and I thi
On 02/07/2020 14:12, Daniel Fuchs wrote:
Hi,
Please find below a fix for
8248703 Clarify the behavior of java.net.NetworkInterface::equals
https://bugs.openjdk.java.net/browse/JDK-8248703
CSR: https://bugs.openjdk.java.net/browse/JDK-8248704
webrev: http://cr.openjdk.java.net/~dfuchs
Hi,
Please find below a fix for
8248703 Clarify the behavior of java.net.NetworkInterface::equals
https://bugs.openjdk.java.net/browse/JDK-8248703
CSR:https://bugs.openjdk.java.net/browse/JDK-8248704
webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8248703/webrev.00/
NetworkInterface
