Re: [9] RFR: 8156710: HttpTimeoutException should be thrown if server doesn't respond

2016-05-13 Thread Michael McMahon
Artem, Thanks for doing this. Eventually, the fix will have to be updated to reset the stream, but all the required functionality for that isn't there yet. Also, I think a test which uses the test http2 server will be needed. But, for now, the fix looks fine. - Michael. On 12/05/16 22:10, Art

[9] RFR: 8156710: HttpTimeoutException should be thrown if server doesn't respond

2016-05-12 Thread Artem Smotrakov
Hello, Please review this for 9. Stream.getResponse() method can hang because it calls join() method without any timeout. It would be better if it took into account a timeout value specified for a connection, and threw HttpTimeoutException if timeout was reached. The patch updates Stream.ge