Code change looks fine.
Thanks
Max
> On Mar 7, 2015, at 13:05, Jason Uh wrote:
>
> While these methods are going to be removed soon anyway, @Deprecated actually
> seems like the more appropriate choice because we do want to discourage use
> of these methods, even if they are non-public APIs.
While these methods are going to be removed soon anyway, @Deprecated
actually seems like the more appropriate choice because we do want to
discourage use of these methods, even if they are non-public APIs.
Here it is with that change; please take a look:
http://cr.openjdk.java.net/~juh/8073430/
What is the policy for deprecating a non-public-API method?
> On Mar 6, 2015, at 13:30, Wang Weijun wrote:
>
> Instead of adding @SupressWarnings to a method, can we add @Deprecated to it?
Instead of adding @SupressWarnings to a method, can we add @Deprecated to it?
If I understand correctly, there should be no warning if a deprecated method
calls another deprecated method. And by deprecating the caller we will get
warnings if they are called by more methods and we can evaluate if
Hi Max,
A couple of these, we probably won't be able to remove in JDK 9. I'm
deprecating getPeerCertificateChain() in the javax.net.ssl.SSLSession
interface in this change, so the implementation in
sun.security.ssl.SSLSessionImpl will have to be suppressed. Also,
X509V1CertImpl will probably
Looks good, Jason, just a couple of comments:
- Add an @Deprecated annotation to the package-info.java files since the
entire package is deprecated. Put {@code} around the package/class names.
- add a noreg label to the bug
--Sean
On 03/04/2015 02:02 PM, Jason Uh wrote:
webrev: http://cr.op
webrev: http://cr.openjdk.java.net/~juh/8073430/00/
jbs: https://bugs.openjdk.java.net/browse/JDK-8073430
Please review this change, which deprecates the classes in
java.security.acl and javax.security.cert. These packages have been
superseded by replacements for a long time.
For java.securit
Hi Jason
I noticed several "@SuppressWarnings("deprecation")" in some sun.* or com.sun.*
classes and it makes me feel uncomfortable. The usage of this annotation, if I
understand correctly, means we know we should not use it but we have to use it
because we are lazy or there are no better alter
